From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations
Date: Fri, 23 Aug 2013 20:34:17 +0200 [thread overview]
Message-ID: <5217AB29.9020209@gmail.com> (raw)
In-Reply-To: <5217A5AE.6090704@cogentembedded.com>
On 23.08.2013 20:10, Sergei Shtylyov wrote:
> On 08/23/2013 06:16 PM, Daniel Mack wrote:
>> priv->coal_intvl = 0;
>> priv->bus_freq_mhz = clk_get_rate(priv->clk) / 1000000;
>>
>> - priv->cpsw_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!priv->cpsw_res) {
>> + ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + if (!ss_res) {
>
> You don't need to check the result of platform_get_resource() if you call
> devm_ioremap_resource() right afterwards -- it will check resource ptr for
> NULL the first thing. :-)
Thanks! Will address that in v5.
Daniel
next prev parent reply other threads:[~2013-08-23 18:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 14:16 [PATCH v4 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 14:16 ` [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:34 ` Daniel Mack [this message]
2013-08-23 14:16 ` [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 16:21 ` Daniel Mack
2013-08-23 17:37 ` Sergei Shtylyov
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw compatible string Daniel Mack
2013-08-23 14:23 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw " Santosh Shilimkar
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:19 ` Santosh Shilimkar
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 6:45 ` Sekhar Nori
2013-08-23 17:23 ` Mugunthan V N
2013-08-26 5:22 ` Gupta, Pekon
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 14:16 ` [PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 14:16 ` [PATCH v4 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217AB29.9020209@gmail.com \
--to=zonque@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).