From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: at91: add support for OUTPUT config
Date: Wed, 28 Aug 2013 16:01:36 +0200 [thread overview]
Message-ID: <521E02C0.9010003@overkiz.com> (raw)
In-Reply-To: <CACRpkdZ+TRb9OFTMHFCW6FYP10hNJFbuods04XK8=zq4bC8cHg@mail.gmail.com>
On 28/08/2013 15:48, Linus Walleij wrote:
> On Wed, Aug 28, 2013 at 3:46 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Tue, Aug 27, 2013 at 4:51 PM, Boris BREZILLON
>> <b.brezillon@overkiz.com> wrote:
>>
>>> Add support for pin output control through the pinctrl config:
>>> - support enabling/disabling output on a given pin
>>> - support output level setting (high or low)
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> NAK.
>>
>> We already have this:
>>
>> * @PIN_CONFIG_OUTPUT: this will configure the pin in output, use argument
>> * 1 to indicate high level, argument 0 to indicate low level.
>>
>> It also has device tree bindings:
>>
>> output-low - set the pin to output mode with low level
>> output-high - set the pin to output mode with high level
> Bah maybe I'm misunderstanding :-(
>
> So this is not part of the generic pin config series, but something
> stand-alone to augment the existing driver to do this?
This is a proposal to add support for OUTPUT config using native at91
pinconf binding (not generic pinconf binding).
I did this to get support for OUTPUT config quickly.
The generic pinconf binding is still in discussion, and will be added as
soon as at91 maintainers and pinctrl
maintainers agree on how this should be done.
>
> So I just apply this patch right off then?
I don't know, I think we should wait for Jean-Christophe approval.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2013-08-28 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 14:51 [PATCH] pinctrl: at91: add support for OUTPUT config Boris BREZILLON
2013-08-27 15:01 ` boris brezillon
2013-08-28 7:31 ` Nicolas Ferre
2013-08-28 7:35 ` boris brezillon
2013-08-28 7:43 ` Nicolas Ferre
2013-08-28 8:08 ` Nicolas Ferre
2013-08-28 13:46 ` Linus Walleij
2013-08-28 13:48 ` Linus Walleij
2013-08-28 14:01 ` boris brezillon [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-28 7:54 Wenyou Yang
2016-10-31 8:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521E02C0.9010003@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).