* [PATCH] ARM: ep93xx: Don't use modem interface on the second UART
@ 2013-08-29 14:28 Petr Štetiar
2013-09-03 4:36 ` Ryan Mallon
0 siblings, 1 reply; 2+ messages in thread
From: Petr Štetiar @ 2013-08-29 14:28 UTC (permalink / raw)
To: linux-arm-kernel
Second UART doesn't have modem interface, so any attempt to use set_mctrl() it
produce unwanted garbage on the line. There's no such 0x100 register offset
for the second UART either.
Signed-off-by: Petr ?tetiar <ynezz@true.cz>
Cc: Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ryan Mallon <rmallon@gmail.com>
---
arch/arm/mach-ep93xx/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
index df8612f..3f12b88 100644
--- a/arch/arm/mach-ep93xx/core.c
+++ b/arch/arm/mach-ep93xx/core.c
@@ -281,7 +281,7 @@ static AMBA_APB_DEVICE(uart1, "apb:uart1", 0x00041010, EP93XX_UART1_PHYS_BASE,
{ IRQ_EP93XX_UART1 }, &ep93xx_uart_data);
static AMBA_APB_DEVICE(uart2, "apb:uart2", 0x00041010, EP93XX_UART2_PHYS_BASE,
- { IRQ_EP93XX_UART2 }, &ep93xx_uart_data);
+ { IRQ_EP93XX_UART2 }, NULL);
static AMBA_APB_DEVICE(uart3, "apb:uart3", 0x00041010, EP93XX_UART3_PHYS_BASE,
{ IRQ_EP93XX_UART3 }, &ep93xx_uart_data);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: ep93xx: Don't use modem interface on the second UART
2013-08-29 14:28 [PATCH] ARM: ep93xx: Don't use modem interface on the second UART Petr Štetiar
@ 2013-09-03 4:36 ` Ryan Mallon
0 siblings, 0 replies; 2+ messages in thread
From: Ryan Mallon @ 2013-09-03 4:36 UTC (permalink / raw)
To: linux-arm-kernel
On 30/08/13 00:28, Petr ?tetiar wrote:
> Second UART doesn't have modem interface, so any attempt to use set_mctrl() it
> produce unwanted garbage on the line. There's no such 0x100 register offset
> for the second UART either.
>
> Signed-off-by: Petr ?tetiar <ynezz@true.cz>
> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
Hi Petr,
Sorry for the late reply. Added to ep93xx-fixes.
Thanks,
~Ryan
> ---
> arch/arm/mach-ep93xx/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index df8612f..3f12b88 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -281,7 +281,7 @@ static AMBA_APB_DEVICE(uart1, "apb:uart1", 0x00041010, EP93XX_UART1_PHYS_BASE,
> { IRQ_EP93XX_UART1 }, &ep93xx_uart_data);
>
> static AMBA_APB_DEVICE(uart2, "apb:uart2", 0x00041010, EP93XX_UART2_PHYS_BASE,
> - { IRQ_EP93XX_UART2 }, &ep93xx_uart_data);
> + { IRQ_EP93XX_UART2 }, NULL);
>
> static AMBA_APB_DEVICE(uart3, "apb:uart3", 0x00041010, EP93XX_UART3_PHYS_BASE,
> { IRQ_EP93XX_UART3 }, &ep93xx_uart_data);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-03 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 14:28 [PATCH] ARM: ep93xx: Don't use modem interface on the second UART Petr Štetiar
2013-09-03 4:36 ` Ryan Mallon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).