From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support
Date: Tue, 03 Sep 2013 22:27:39 +0400 [thread overview]
Message-ID: <52262A1B.4050406@cogentembedded.com> (raw)
In-Reply-To: <CANqRtoQFYFva9msdoEWdU2Z7_=jOtZwvXgL7OqUKhVMO3NOPzg@mail.gmail.com>
Hello.
On 09/03/2013 07:17 PM, Magnus Damm wrote:
>> Define the generic R8A777x part of the Ether device node.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7778.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7778.dtsi
>> @@ -98,4 +98,15 @@
>> reg = <0xfffc000 0x118>;
>> #gpio-range-cells = <3>;
>> };
>> +
>> + ether: ethernet at fde00000 {
>> + device_type = "network";
>> + compatible = "renesas,ether-r8a7779";
> Hi Sergei,
> Thanks for your patch. What's the reason behind the r8a7778 SoC using
> a compatible string for r8a7779 like "renesas,ether-r8a7779"?
R8A7779 support has appeared first in Linux and as R8A7778 Ether is
identical to R8A7779 and no wildcards are allowed in the device tree, I
decided to use this "compatible" prop.
> It seems that you assume that the r8a7778 ethernet controller is 100%
> compatible with r8a7779. Is that really true? For earlier versions the
> sh_eth hardware documentation was anything but accurate, so it seems
> to me that it must be more safe that r8a7778 would be using
> "renesas,ether-r8a7778". What do you think?
I think R8A7778 and R8A7779 EtherMACs are identical. I've cross checked
the documentation at the start of the development and the registers appeared
to be the same.
> Thanks,
> / magnus
WBR, Sergei
next prev parent reply other threads:[~2013-09-03 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 23:11 [PATCH 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
2013-08-31 23:15 ` [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-02 13:14 ` Laurent Pinchart
2013-09-02 14:05 ` Sergei Shtylyov
2013-09-02 14:18 ` Laurent Pinchart
2013-09-02 15:32 ` Pawel Moll
2013-09-03 12:11 ` Laurent Pinchart
2013-09-03 13:53 ` Sergei Shtylyov
2013-09-03 15:17 ` Magnus Damm
2013-09-03 18:27 ` Sergei Shtylyov [this message]
2013-09-04 5:35 ` Magnus Damm
2013-09-04 9:39 ` Laurent Pinchart
2013-09-05 6:03 ` Simon Horman
2013-08-31 23:18 ` [PATCH 2/4] ARM: shmobile: r8a7778: add Ether clock for DT case Sergei Shtylyov
2013-08-31 23:22 ` [PATCH 3/4] ARM: shmobile: bockw-reference: add Ether DT support Sergei Shtylyov
2013-08-31 23:24 ` [PATCH 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52262A1B.4050406@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).