From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/8] Add the Quadspi driver for vf610-twr
Date: Thu, 5 Sep 2013 17:30:26 +0800 [thread overview]
Message-ID: <52284F32.2020302@freescale.com> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA0C907@DBDE04.ent.ti.com>
? 2013?09?05? 17:11, Gupta, Pekon ??:
> No, SPI generic framework (struct spi_transfer, spi_message,...)
> should be kept independent of any MTD flash specific data handlers.
> <wangyuhang2014@gmail.com> added two new fields (tx_nbits, rx_nbits)
> to spi_device because those properties are part of SPI protocol.
> But, 'dummy_cycles' is no related to SPI protocol. So it should be kept out
> of SPI generic framework.
> This is where if you could use DT based approach, things would have been
> simpler, because you give end-user the freedom to enter device-info from
> device datasheet.
ok. i think i do not need to change the spi code now.
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>>> > > Example: How to select opcodes in DT ?
>>> > > (step-1) eliminate opcode which cannot be used due to board constrains.
>>> > > your board connects only 2 data I/O between device and controller, So you
>>> > > cannot use any of the QUAD Read opcodes. Thus your choice is limited to
>>> > > DUAL or SINGLE modes only.
>> > we have 4 data I/O lines between the device and controller, i only need
>> > the Quad mode.:)
>> >
> May be because you are currently working on a development EVM or
> demo board, so you can live with QUAD mode.
> But when customer will have custom boards with different QSPI devices
> then you would end-up supporting all sorts of configurations:-)
> And in production scenarios, it?s the price economics which mostly dominates
> which part to choose and how to connect it on board.
> Like as I remember some freescale boards have WINBOND QSPI flash
> which uses different opcodes and semantics, so you might need to support
> that too in future.
>
> So my suggestion is think again. As you are inviting lot of re-work for yourself
> and for others too:-)
>
> Anyway, if you really want to continue with this is, then please re-name
> include/linux/mtd/spi-nor.h to
> include/linux/mtd/spi-fsl-quadspi.h
> because something specific for your driver should not conflict with
> generic spi-nor framework added later.
i think there is no specific thing for this driver. The S25FL128S is a
common flash,
other person may uses it too. Could you show me what is specific?
so, i prefer to spi-nor.h.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-09-05 9:30 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 2:07 [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-08-30 2:07 ` [PATCH v3 1/8] mtd: m25p80: move the spi-nor commands to a header Huang Shijie
2013-08-30 2:07 ` [PATCH v3 2/8] mtd: m25p80: add support for Spansion s25fl128s chip Huang Shijie
2013-08-30 2:07 ` [PATCH v3 3/8] mtd: m25p80: add the quad-read support Huang Shijie
2013-08-30 2:07 ` [PATCH v3 4/8] mtd: m25p80: add the DDR " Huang Shijie
2013-08-30 2:07 ` [PATCH v3 5/8] spi: Add Freescale QuadSpi driver Huang Shijie
2013-09-10 18:09 ` Mark Brown
2013-09-11 2:40 ` Huang Shijie
2013-09-11 10:39 ` Mark Brown
2013-08-30 2:07 ` [PATCH v3 6/8] Documentation: add the binding file for Quadspi driver Huang Shijie
2013-08-30 2:07 ` [PATCH v3 7/8] ARM: dts: vf610: change the PAD values for Quadspi Huang Shijie
2013-08-30 2:07 ` [PATCH v3 8/8] ARM: dts: vf610-twr: Add SPI NOR support Huang Shijie
2013-09-04 2:16 ` [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-09-04 9:55 ` Mark Brown
2013-09-04 10:29 ` Huang Shijie
2013-09-04 11:33 ` Mark Brown
2013-09-05 1:43 ` Huang Shijie
2013-09-04 13:45 ` thomas.langer at lantiq.com
2013-09-05 2:04 ` Huang Shijie
2013-09-05 4:25 ` Gupta, Pekon
2013-09-05 5:34 ` Huang Shijie
2013-09-05 6:32 ` Gupta, Pekon
2013-09-05 7:45 ` Huang Shijie
2013-09-05 9:11 ` Gupta, Pekon
2013-09-05 9:30 ` Huang Shijie [this message]
2013-09-05 13:50 ` Mark Brown
2013-09-06 2:36 ` Huang Shijie
2013-09-08 13:47 ` Mark Brown
2013-09-09 3:07 ` Huang Shijie
2013-09-09 15:14 ` Mark Brown
2013-09-10 6:59 ` Huang Shijie
2013-09-10 18:07 ` Mark Brown
2013-09-11 2:38 ` Huang Shijie
2013-09-11 10:41 ` Mark Brown
2013-09-11 10:54 ` Huang Shijie
2013-09-11 11:30 ` Mark Brown
2013-09-11 12:26 ` Gupta, Pekon
2013-09-11 12:35 ` Mark Brown
2013-09-12 9:18 ` Huang Shijie
2013-09-12 10:20 ` Mark Brown
2013-09-13 3:30 ` Huang Shijie
2013-09-12 15:32 ` David Woodhouse
2013-09-12 10:39 ` David Woodhouse
2013-09-12 10:56 ` Gupta, Pekon
2013-09-12 11:17 ` David Woodhouse
2013-09-12 11:48 ` Mark Brown
2013-09-12 11:55 ` Russell King - ARM Linux
2013-09-12 13:24 ` Mark Brown
2013-09-12 13:25 ` Ricard Wanderlof
2013-09-12 14:10 ` Russell King - ARM Linux
2013-09-12 12:02 ` David Woodhouse
2013-09-12 13:43 ` Mark Brown
2013-09-12 14:03 ` David Woodhouse
2013-09-12 14:40 ` Mark Brown
2013-09-13 3:14 ` Huang Shijie
2013-09-11 14:05 ` David Woodhouse
2013-09-11 15:07 ` Mark Brown
[not found] ` <20130909151450 <52318953.6090405@freescale.com>
[not found] ` <52318953.6090405@freescale.com>
2013-09-12 9:50 ` David Woodhouse
2013-09-12 10:19 ` Mark Brown
2013-09-13 2:58 ` Huang Shijie
2013-09-12 15:22 ` David Woodhouse
2013-09-13 4:12 ` Huang Shijie
2013-09-12 16:26 ` David Woodhouse
2013-09-13 3:06 ` Huang Shijie
2013-09-12 16:27 ` Fabio Estevam
2013-09-13 2:21 ` Huang Shijie
2013-09-12 20:56 ` Mark Brown
2013-09-13 4:55 ` Huang Shijie
2013-09-13 10:21 ` Mark Brown
2013-09-16 2:40 ` Huang Shijie
2013-09-16 10:19 ` Mark Brown
2013-09-16 10:27 ` Huang Shijie
2013-09-16 11:06 ` Mark Brown
2013-09-17 2:14 ` Huang Shijie
2013-09-17 10:51 ` Mark Brown
2013-09-17 15:05 ` Gerhard Sittig
2013-09-17 16:49 ` Gerhard Sittig
2013-09-17 19:54 ` Sourav Poddar
2013-09-17 19:13 ` Mark Brown
2013-09-18 15:40 ` David Woodhouse
2013-09-18 16:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52284F32.2020302@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).