From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc
Date: Mon, 09 Sep 2013 10:02:04 -0600 [thread overview]
Message-ID: <522DF0FC.5080200@wwwdotorg.org> (raw)
In-Reply-To: <1378712154-30602-1-git-send-email-linus.walleij@linaro.org>
On 09/09/2013 01:35 AM, Linus Walleij wrote:
> The way I read the Tegra AES RNG is that it has a homebrew
> algorithm for initializing the 128bit RNG using timespec and
> the unique chip ID. This looks like reinventing the (square)
> wheel, instead just grab 128bits from the kernel entropy pool
> where the time and (after another patch) chip unique ID is
> already mixed in.
>
> Incidentally this also gets rid of a rather ugly
> cross-dependence on the machine using an extern declaration.
This sounds reasonable to me, although I know little about the driver.
Varun, can you please comment?
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2013-09-09 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 7:35 [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc Linus Walleij
2013-09-09 16:02 ` Stephen Warren [this message]
[not found] ` <20130913122318.GD8579@gondor.apana.org.au>
2013-09-13 16:12 ` Stephen Warren
[not found] ` <20130913233912.GA16389@gondor.apana.org.au>
2013-09-16 15:28 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DF0FC.5080200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).