From: rvaswani@codeaurora.org (Rohit Vaswani)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard
Date: Mon, 09 Sep 2013 15:30:36 -0700 [thread overview]
Message-ID: <522E4C0C.6080309@codeaurora.org> (raw)
In-Reply-To: <49CC46F4-F6CE-4B1A-B0D5-E4BB779755B8@codeaurora.org>
On 9/9/2013 3:04 PM, Kumar Gala wrote:
> On Sep 9, 2013, at 4:42 PM, Rohit Vaswani wrote:
>
>> On 9/9/2013 2:25 PM, Kumar Gala wrote:
>>> <snip>
>>> On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote:
>>>>>>>>>> This patch adds basic board support for APQ8074 Dragonboard
>>>>>>>>>> <snip>
>>>>>>>>>> dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>>>>>>>>>> - msm8960-cdp.dtb
>>>>>>>>>> + msm8960-cdp.dtb \
>>>>>>>>>> + apq8074-dragonboard.dtb
>>>>>>>>> Please add boards alphabetically.
>>>>>>>> Will do.
>>>>>>>>>> dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
>>>>>>>>>> armada-370-mirabox.dtb \
>>>>>>>>>> armada-370-rd.dtb \
>>>>>>>>>> diff --git a/arch/arm/boot/dts/apq8074-dragonboard.dts b/arch/arm/boot/dts/apq8074-dragonboard.dts
>>>>>>>>>> new file mode 100644
>>>>>>>>>> index 0000000..5b7b6a0
>>>>>>>>>> --- /dev/null
>>>>>>>>>> +++ b/arch/arm/boot/dts/apq8074-dragonboard.dts
>>>>>>>>> arch/arm/boot/dts/ is getting really crowded. It's been working best if the SoC
>>>>>>>>> family or vendor is used as a prefix to keep things a bit more organized. In
>>>>>>>>> that spirit, prefixing these with msm-<foo> makes sense. Can you please do so?
>>>>>>>> Sure. But the board is called an APQ8074 and we wanted to keep the naming consistent with that.
>>>>>>> If we do this we should use qcom, not msm as the prefix. Match the device tree vendor prefix.
>> Coming back to this, it would be better if the naming to be consistent with what we call our ARCH - msm and not qcom.
>> msm8974-dragonboard signifies quite clearly what the board is.
> I was saying qcom,apq8074-dragonboard or we can do the dir thing as we don't have that mean qcom/msm device trees.
>
> - k
Sure, that's fine. If there's a consensus on the name to match the
compatible strings, could you send a patch out to rename the older
dtsi's and I can add the Dragonboard support with it.
Thanks,
Rohit Vaswani
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2013-09-09 22:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 19:32 [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Rohit Vaswani
2013-09-06 19:32 ` [PATCHv3 2/2] defconfig: msm_defconfig: Enable CONFIG_ARCH_MSM8974 Rohit Vaswani
2013-09-06 19:53 ` [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Josh Cartwright
2013-09-06 20:31 ` [PATCH] ARM: msm: Remove irqs-*.h files for DT based targets Stephen Boyd
2013-09-06 20:50 ` Stephen Boyd
2013-09-06 20:55 ` Josh Cartwright
2013-09-06 21:50 ` [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Olof Johansson
2013-09-09 17:48 ` Rohit Vaswani
2013-09-09 19:17 ` Kumar Gala
2013-09-09 19:29 ` Stephen Warren
2013-09-09 19:48 ` Kumar Gala
2013-09-09 21:21 ` Stephen Warren
2013-09-09 21:25 ` Kumar Gala
2013-09-09 21:42 ` Rohit Vaswani
2013-09-09 22:04 ` Kumar Gala
2013-09-09 22:30 ` Rohit Vaswani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522E4C0C.6080309@codeaurora.org \
--to=rvaswani@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).