* [PATCH] ARM: davinci: fix build breakage with DEBUG_LL
@ 2013-09-10 13:23 Sekhar Nori
2013-09-10 13:36 ` Alexander Holler
0 siblings, 1 reply; 3+ messages in thread
From: Sekhar Nori @ 2013-09-10 13:23 UTC (permalink / raw)
To: linux-arm-kernel
commit fcf7157 ("ARM: davinci: serial: get rid of davinci_uart_config")
introduced build breakage because of a misplaced
header file include which cause a bunch of errors when
the file is included in assembly code (like debug-macro.S)
Fix the build breakage.
Reported-by: Alexander Holler <holler@ahsoftware.de>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
Applies to latest linus/master
arch/arm/mach-davinci/include/mach/serial.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-davinci/include/mach/serial.h b/arch/arm/mach-davinci/include/mach/serial.h
index 52b8571..ce402cd 100644
--- a/arch/arm/mach-davinci/include/mach/serial.h
+++ b/arch/arm/mach-davinci/include/mach/serial.h
@@ -15,8 +15,6 @@
#include <mach/hardware.h>
-#include <linux/platform_device.h>
-
#define DAVINCI_UART0_BASE (IO_PHYS + 0x20000)
#define DAVINCI_UART1_BASE (IO_PHYS + 0x20400)
#define DAVINCI_UART2_BASE (IO_PHYS + 0x20800)
@@ -39,6 +37,8 @@
#define UART_DM646X_SCR_TX_WATERMARK 0x08
#ifndef __ASSEMBLY__
+#include <linux/platform_device.h>
+
extern int davinci_serial_init(struct platform_device *);
#endif
--
1.7.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: davinci: fix build breakage with DEBUG_LL
2013-09-10 13:23 [PATCH] ARM: davinci: fix build breakage with DEBUG_LL Sekhar Nori
@ 2013-09-10 13:36 ` Alexander Holler
2013-09-10 14:50 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Holler @ 2013-09-10 13:36 UTC (permalink / raw)
To: linux-arm-kernel
Hello Sekhar,
just what I did here to fix it. So you can add a Tested-By or Acked-By
if you wish.
Thanks,
Alexander Holler
Am 10.09.2013 15:23, schrieb Sekhar Nori:
> commit fcf7157 ("ARM: davinci: serial: get rid of davinci_uart_config")
> introduced build breakage because of a misplaced
> header file include which cause a bunch of errors when
> the file is included in assembly code (like debug-macro.S)
>
> Fix the build breakage.
>
> Reported-by: Alexander Holler <holler@ahsoftware.de>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Applies to latest linus/master
>
> arch/arm/mach-davinci/include/mach/serial.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/include/mach/serial.h b/arch/arm/mach-davinci/include/mach/serial.h
> index 52b8571..ce402cd 100644
> --- a/arch/arm/mach-davinci/include/mach/serial.h
> +++ b/arch/arm/mach-davinci/include/mach/serial.h
> @@ -15,8 +15,6 @@
>
> #include <mach/hardware.h>
>
> -#include <linux/platform_device.h>
> -
> #define DAVINCI_UART0_BASE (IO_PHYS + 0x20000)
> #define DAVINCI_UART1_BASE (IO_PHYS + 0x20400)
> #define DAVINCI_UART2_BASE (IO_PHYS + 0x20800)
> @@ -39,6 +37,8 @@
> #define UART_DM646X_SCR_TX_WATERMARK 0x08
>
> #ifndef __ASSEMBLY__
> +#include <linux/platform_device.h>
> +
> extern int davinci_serial_init(struct platform_device *);
> #endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: davinci: fix build breakage with DEBUG_LL
2013-09-10 13:36 ` Alexander Holler
@ 2013-09-10 14:50 ` Sekhar Nori
0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2013-09-10 14:50 UTC (permalink / raw)
To: linux-arm-kernel
On 9/10/2013 7:06 PM, Alexander Holler wrote:
> Hello Sekhar,
>
> just what I did here to fix it. So you can add a Tested-By or Acked-By
> if you wish.
Sure. I will add your Tested-By.
Regards,
Sekhar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-10 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 13:23 [PATCH] ARM: davinci: fix build breakage with DEBUG_LL Sekhar Nori
2013-09-10 13:36 ` Alexander Holler
2013-09-10 14:50 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).