From: "Xiangzhi Tang (唐相志)" <Xiangzhi.Tang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Hailong Fan (范海龙)" <Hailong.Fan@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Jjian Zhou (周建)" <Jjian.Zhou@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"andersson@kernel.org" <andersson@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: Add VCP support for mt8196
Date: Sun, 6 Apr 2025 08:04:52 +0000 [thread overview]
Message-ID: <522befcba0d8e5efe089b6fb22049cd74cfb4ead.camel@mediatek.com> (raw)
In-Reply-To: <174359852621.53914.11998352307162389918.robh@kernel.org>
On Wed, 2025-04-02 at 07:55 -0500, Rob Herring (Arm) wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Wed, 02 Apr 2025 17:19:24 +0800, Xiangzhi Tang wrote:
> > Add the new binding document for MediaTek Video Companion
> > Processor(VCP) on MediaTek mt8196.
> >
> > Signed-off-by: Xiangzhi Tang <xiangzhi.tang@mediatek.com>
> > ---
> > .../remoteproc/mediatek,mt8196-vcp.yaml | 174
> > ++++++++++++++++++
> > 1 file changed, 174 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> > vcp.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.example.dts:26:18: fatal error: dt-bindings/power/mt8196-power.h:
> No such file or directory
> 26 | #include <dt-bindings/power/mt8196-power.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.dtbs:131:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522:
> dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
> Warning:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml
> references a file that doesn't exist:
> Documentation/devicetree/bindings/mailbox/mediatek,mt8196-vcp-
> mbox.yaml
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.yaml: Documentation/devicetree/bindings/mailbox/mediatek,mt8196-
> vcp-mbox.yaml
>
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250402092134.12293-2-xiangzhi.tang@mediatek.com
>
> The base for the series is generally the latest rc1. A different
> dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself.
> Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up
> checking
> your schema. However, it must be unset to test all examples with your
> schema.
> I run test "make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/mediatek,m
t8196-vcp.yaml", And, I have to cherry-pick first "
https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
" and "
https://patchwork.kernel.org/project/linux-mediatek/patch/20250317110331.2776-4-jjian.zhou@mediatek.com/
"
>
next prev parent reply other threads:[~2025-04-06 8:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 9:19 [PATCH 0/2] Add vcp driver Xiangzhi Tang
2025-04-02 9:19 ` [PATCH 1/2] dt-bindings: remoteproc: Add VCP support for mt8196 Xiangzhi Tang
2025-04-02 11:11 ` Krzysztof Kozlowski
2025-04-06 6:46 ` Xiangzhi Tang (唐相志)
2025-04-06 12:10 ` Krzysztof Kozlowski
2025-04-02 12:55 ` Rob Herring (Arm)
2025-04-06 8:04 ` Xiangzhi Tang (唐相志) [this message]
2025-04-02 9:19 ` [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver Xiangzhi Tang
2025-04-02 11:16 ` Krzysztof Kozlowski
2025-04-06 7:29 ` Xiangzhi Tang (唐相志)
2025-04-06 12:12 ` Krzysztof Kozlowski
2025-04-02 14:19 ` Mathieu Poirier
2025-04-02 10:31 ` [PATCH 0/2] Add vcp driver Krzysztof Kozlowski
2025-04-06 8:05 ` Xiangzhi Tang (唐相志)
2025-04-06 12:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522befcba0d8e5efe089b6fb22049cd74cfb4ead.camel@mediatek.com \
--to=xiangzhi.tang@mediatek.com \
--cc=Hailong.Fan@mediatek.com \
--cc=Jjian.Zhou@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).