From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 18/38] iio: sensors-core: st: Allow full-scale to be an optional feature
Date: Sat, 14 Sep 2013 17:45:47 +0100 [thread overview]
Message-ID: <523492BB.5070004@kernel.org> (raw)
In-Reply-To: <1378817379-8238-19-git-send-email-lee.jones@linaro.org>
On 09/10/13 13:49, Lee Jones wrote:
> Some chips either don't support it or fail to provide adequate documentation,
> so sometimes it's impossible to enable the feature even if it is supported.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to the togreg branch of iio.git
Thanks
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 11 +++++++----
> drivers/iio/pressure/st_pressure_core.c | 6 ++++--
> 2 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 965ee22..eb261a5 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -235,10 +235,13 @@ int st_sensors_init_sensor(struct iio_dev *indio_dev,
> if (err < 0)
> goto init_error;
>
> - err = st_sensors_set_fullscale(indio_dev,
> - sdata->current_fullscale->num);
> - if (err < 0)
> - goto init_error;
> + if (sdata->current_fullscale) {
> + err = st_sensors_set_fullscale(indio_dev,
> + sdata->current_fullscale->num);
> + if (err < 0)
> + goto init_error;
> + } else
> + dev_info(&indio_dev->dev, "Full-scale not possible\n");
>
> err = st_sensors_set_odr(indio_dev, sdata->odr);
> if (err < 0)
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index ceebd3c..16cfbc5 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -226,8 +226,10 @@ int st_press_common_probe(struct iio_dev *indio_dev,
> indio_dev->channels = pdata->sensor->ch;
> indio_dev->num_channels = ARRAY_SIZE(st_press_channels);
>
> - pdata->current_fullscale = (struct st_sensor_fullscale_avl *)
> - &pdata->sensor->fs.fs_avl[0];
> + if (pdata->sensor->fs.addr != 0)
> + pdata->current_fullscale = (struct st_sensor_fullscale_avl *)
> + &pdata->sensor->fs.fs_avl[0];
> +
> pdata->odr = pdata->sensor->odr.odr_avl[0].hz;
>
> if (!plat_data)
>
next prev parent reply other threads:[~2013-09-14 16:45 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 12:49 [PATCH v3 00/38] iio: ST clean-ups and new sensor support Lee Jones
2013-09-10 12:49 ` [PATCH 01/38] ARM: ux500: Remove PrimeCell IDs from Nomadik I2C DT nodes Lee Jones
2013-09-10 15:23 ` Olof Johansson
2013-09-10 15:30 ` Lee Jones
2013-09-10 16:57 ` Olof Johansson
2013-09-11 8:06 ` Linus Walleij
2013-09-11 8:19 ` Lee Jones
2013-09-11 9:33 ` Linus Walleij
[not found] ` <CAF2Aj3iPdqM-+FQ7R9MZ-6jV1Q1me9TG1P4cEGA7fSBBYH92zA@mail.gmail.com>
2013-09-11 11:13 ` Linus Walleij
2013-09-11 20:36 ` Olof Johansson
2013-09-12 12:23 ` Linus Walleij
2013-09-12 12:32 ` Russell King - ARM Linux
2013-09-11 8:17 ` Lee Jones
2013-09-10 12:49 ` [PATCH 02/38] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT Lee Jones
2013-09-10 12:49 ` [PATCH 03/38] ARM: ux500: Enable the LSM303DLH Accelerator " Lee Jones
2013-09-10 12:49 ` [PATCH 04/38] ARM: ux500: Enable the LSM303DLH Magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 05/38] ARM: ux500: Enable the L3G4200D Gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 06/38] ARM: ux500: CONFIG: Enable ST's IIO Pressure Sensors by default Lee Jones
2013-09-10 12:49 ` [PATCH 07/38] ARM: ux500: CONFIG: Enable ST's IIO Accelerometer " Lee Jones
2013-09-10 15:20 ` Olof Johansson
2013-09-10 15:35 ` Lee Jones
2013-09-10 16:51 ` Olof Johansson
2013-09-11 7:20 ` Lee Jones
2013-09-10 12:49 ` [PATCH 08/38] ARM: ux500: CONFIG: Enable ST's IIO Magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 09/38] ARM: ux500: CONFIG: Enable ST's IIO Gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 10/38] Documentation: dt: iio: Add binding for LPS001WP Lee Jones
2013-09-14 12:08 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 11/38] Documentation: dt: iio: Add binding for LSM303DLH Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 12/38] Documentation: dt: iio: Add binding for L3G4200D Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 13/38] Documentation: dt: iio: Add binding for LSM303DLH Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names Lee Jones
2013-09-14 12:14 ` Jonathan Cameron
2013-09-14 12:27 ` Jonathan Cameron
2013-09-16 8:33 ` Lars-Peter Clausen
2013-09-16 9:21 ` Denis CIOCCA
2013-09-16 12:03 ` Lars-Peter Clausen
2013-09-16 19:15 ` Jonathan Cameron
2013-09-16 13:31 ` Lee Jones
2013-09-16 13:43 ` Lars-Peter Clausen
2013-09-16 19:17 ` Jonathan Cameron
2013-09-17 8:05 ` Lee Jones
2013-09-10 12:49 ` [PATCH 15/38] iio: gyro: st: Append _gyro to gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 16/38] iio: magn: st: Append _magn to magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 17/38] iio: press: st: Append _press to pressure " Lee Jones
2013-09-10 12:49 ` [PATCH 18/38] iio: sensors-core: st: Allow full-scale to be an optional feature Lee Jones
2013-09-14 16:45 ` Jonathan Cameron [this message]
2013-09-14 17:07 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 19/38] iio: sensors-core: st: Support sensors which don't have a Data Ready pin Lee Jones
2013-09-14 16:53 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 20/38] iio: sensors-core: st: Clean-up error handling in st_sensors_init_sensor() Lee Jones
2013-09-14 16:54 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 21/38] iio: sensors-core: st: Clean-up error handling in st_sensors_read_axis_data() Lee Jones
2013-09-14 16:58 ` Jonathan Cameron
2013-09-16 8:22 ` Lee Jones
2013-09-10 12:49 ` [PATCH 22/38] iio: sensors-core: st: Clean-up error handling in st_sensors_read_info_raw() Lee Jones
2013-09-14 17:01 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 23/38] iio: pressure-core: st: Describe LPS331AP defines by name Lee Jones
2013-09-14 17:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 24/38] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor Lee Jones
2013-09-14 17:14 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 25/38] iio: pressure-core: st: Allow for number of channels to vary Lee Jones
2013-09-14 17:18 ` Jonathan Cameron
2013-09-16 8:17 ` Lee Jones
2013-09-16 15:32 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 26/38] iio: pressure-core: st: Clean-up probe() function Lee Jones
2013-09-10 16:23 ` Jonathan Cameron
2013-09-11 7:19 ` Lee Jones
2013-09-14 17:21 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 27/38] iio: pressure-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 16:25 ` Jonathan Cameron
2013-09-11 7:10 ` Lee Jones
2013-09-11 7:18 ` Lars-Peter Clausen
2013-09-11 7:29 ` Lee Jones
2013-09-11 15:35 ` Mark Brown
2013-09-13 20:57 ` Getz, Robin
2013-09-16 9:47 ` Lee Jones
2013-09-11 18:30 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 28/38] iio: pressure: st: Add support for new LPS001WP pressure sensor Lee Jones
2013-09-14 17:26 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 29/38] iio: pressure-core: st: Provide support for the Vdd power supply Lee Jones
2013-09-14 17:28 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 30/38] iio: pressure-core: st: Provide support for the Vdd_IO " Lee Jones
2013-09-10 12:49 ` [PATCH 31/38] iio: accel-core: st: Clean up error handling in probe() Lee Jones
2013-09-14 17:31 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 32/38] iio: accel-core: st: Move LSM303DLH into correct group Lee Jones
2013-09-14 17:51 ` Jonathan Cameron
2013-09-16 8:05 ` Lee Jones
2013-09-16 9:19 ` Denis CIOCCA
2013-09-16 9:38 ` Lee Jones
2013-09-16 9:57 ` Denis CIOCCA
2013-09-16 10:19 ` Lee Jones
2013-09-16 10:23 ` Denis CIOCCA
2013-09-16 11:08 ` Lee Jones
2013-09-10 12:49 ` [PATCH 33/38] iio: accel-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 34/38] iio: gyro-core: st: Clean up error handling in probe() Lee Jones
2013-09-10 12:49 ` [PATCH 35/38] iio: gyro-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 36/38] iio: magn-core: st: Clean up error handling in probe() Lee Jones
2013-09-10 12:49 ` [PATCH 37/38] iio: magn-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 38/38] iio: magn-core: st: Provide support for the LSM303DLH Lee Jones
2013-09-14 17:53 ` Jonathan Cameron
2013-09-16 7:31 ` Lee Jones
2013-09-16 9:32 ` Denis CIOCCA
2013-09-16 10:08 ` Lee Jones
2013-09-16 10:18 ` Denis CIOCCA
2013-09-16 11:11 ` Lee Jones
2013-09-16 11:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523492BB.5070004@kernel.org \
--to=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).