* [PATCH] ARM: dts: DRA7: provide arch-timer frequenecy parameter
@ 2013-09-17 16:47 Nishanth Menon
2013-09-17 16:55 ` Santosh Shilimkar
0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2013-09-17 16:47 UTC (permalink / raw)
To: linux-arm-kernel
CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
same. Without a valid value arch_timer_init results in div0 crash.
Providing the same is a safer alternative.
Cc: R Sricharan <r.sricharan@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Based on Benoit's for_3.13/dts branch.
http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
Without this patch, div0 error occurs(seen on 3.12-rc1 tag): http://pastebin.com/B2sDauS9
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index c01ef76..b478beb 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -50,6 +50,7 @@
<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
+ clock-frequency = <6144000>;
};
gic: interrupt-controller at 48211000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: DRA7: provide arch-timer frequenecy parameter
2013-09-17 16:47 [PATCH] ARM: dts: DRA7: provide arch-timer frequenecy parameter Nishanth Menon
@ 2013-09-17 16:55 ` Santosh Shilimkar
2013-09-17 17:01 ` [PATCH V2] " Nishanth Menon
0 siblings, 1 reply; 6+ messages in thread
From: Santosh Shilimkar @ 2013-09-17 16:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 17 September 2013 12:47 PM, Nishanth Menon wrote:
> CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
> same. Without a valid value arch_timer_init results in div0 crash.
s/same/timer frequency via DT
> Providing the same is a safer alternative.
Above statement won't be necessary.
> Cc: R Sricharan <r.sricharan@ti.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Sourav Poddar <sourav.poddar@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
Apart from minor change log fix,
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] ARM: dts: DRA7: provide arch-timer frequenecy parameter
2013-09-17 16:55 ` Santosh Shilimkar
@ 2013-09-17 17:01 ` Nishanth Menon
2013-09-18 11:33 ` Sricharan R
0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2013-09-17 17:01 UTC (permalink / raw)
To: linux-arm-kernel
CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
timer frequency via DT. Without a valid value arch_timer_init results
in div0 crash.
Cc: R Sricharan <r.sricharan@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Based on Benoit's for_3.13/dts branch.
http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
Crash log: http://pastebin.com/B2sDauS9
V2: commit message update
V1: https://patchwork.kernel.org/patch/2903261/
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index c98997b..71c2749 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -50,6 +50,7 @@
<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
+ clock-frequency = <6144000>;
};
gic: interrupt-controller at 48211000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: DRA7: provide arch-timer frequenecy parameter
2013-09-17 17:01 ` [PATCH V2] " Nishanth Menon
@ 2013-09-18 11:33 ` Sricharan R
2013-09-18 13:02 ` Nishanth Menon
2013-09-18 13:23 ` Santosh Shilimkar
0 siblings, 2 replies; 6+ messages in thread
From: Sricharan R @ 2013-09-18 11:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tuesday 17 September 2013 10:31 PM, Nishanth Menon wrote:
> CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
> timer frequency via DT. Without a valid value arch_timer_init results
> in div0 crash.
>
> Cc: R Sricharan <r.sricharan@ti.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Sourav Poddar <sourav.poddar@ti.com>
>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Based on Benoit's for_3.13/dts branch.
> http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
>
> Crash log: http://pastebin.com/B2sDauS9
>
> V2: commit message update
> V1: https://patchwork.kernel.org/patch/2903261/
>
> arch/arm/boot/dts/dra7.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index c98997b..71c2749 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -50,6 +50,7 @@
> <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
> + clock-frequency = <6144000>;
> };
>
> gic: interrupt-controller at 48211000 {
This is not the right way to pass the frequency. In fact, initially the frequency value was present
when the dts was added, but had to revert it back based on the feedbacks. Please refer below.
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg93832.html
Also posted the below patch to fix this,
http://marc.info/?l=linux-omap&m=137950345528918&w=2
Regards,
Sricharan
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: DRA7: provide arch-timer frequenecy parameter
2013-09-18 11:33 ` Sricharan R
@ 2013-09-18 13:02 ` Nishanth Menon
2013-09-18 13:23 ` Santosh Shilimkar
1 sibling, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2013-09-18 13:02 UTC (permalink / raw)
To: linux-arm-kernel
On 09/18/2013 06:33 AM, Sricharan R wrote:
> Hi,
>
> On Tuesday 17 September 2013 10:31 PM, Nishanth Menon wrote:
>> CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
>> timer frequency via DT. Without a valid value arch_timer_init results
>> in div0 crash.
>>
>> Cc: R Sricharan <r.sricharan@ti.com>
>> Cc: Rajendra Nayak <rnayak@ti.com>
>> Cc: Sourav Poddar <sourav.poddar@ti.com>
>>
>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>
>> Based on Benoit's for_3.13/dts branch.
>> http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
>>
>> Crash log: http://pastebin.com/B2sDauS9
>>
>> V2: commit message update
>> V1: https://patchwork.kernel.org/patch/2903261/
>>
>> arch/arm/boot/dts/dra7.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index c98997b..71c2749 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -50,6 +50,7 @@
>> <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
>> <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
>> <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
>> + clock-frequency = <6144000>;
>> };
>>
>> gic: interrupt-controller at 48211000 {
> This is not the right way to pass the frequency. In fact, initially the frequency value was present
> when the dts was added, but had to revert it back based on the feedbacks. Please refer below.
>
>
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg93832.html
>
>
> Also posted the below patch to fix this,
>
> http://marc.info/?l=linux-omap&m=137950345528918&w=2
Thanks for a better alternative. at least my boot tests indicate that
the patch works fine.
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: DRA7: provide arch-timer frequenecy parameter
2013-09-18 11:33 ` Sricharan R
2013-09-18 13:02 ` Nishanth Menon
@ 2013-09-18 13:23 ` Santosh Shilimkar
1 sibling, 0 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2013-09-18 13:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 18 September 2013 07:33 AM, Sricharan R wrote:
> Hi,
>
> On Tuesday 17 September 2013 10:31 PM, Nishanth Menon wrote:
>> CNTFREQ isn't pre-programmed on DRA7 just like O5, so provide the
>> timer frequency via DT. Without a valid value arch_timer_init results
>> in div0 crash.
>>
>> Cc: R Sricharan <r.sricharan@ti.com>
>> Cc: Rajendra Nayak <rnayak@ti.com>
>> Cc: Sourav Poddar <sourav.poddar@ti.com>
>>
>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>
>> Based on Benoit's for_3.13/dts branch.
>> http://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
>>
>> Crash log: http://pastebin.com/B2sDauS9
>>
>> V2: commit message update
>> V1: https://patchwork.kernel.org/patch/2903261/
>>
>> arch/arm/boot/dts/dra7.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index c98997b..71c2749 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -50,6 +50,7 @@
>> <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
>> <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
>> <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
>> + clock-frequency = <6144000>;
>> };
>>
>> gic: interrupt-controller at 48211000 {
> This is not the right way to pass the frequency. In fact, initially the frequency value was present
> when the dts was added, but had to revert it back based on the feedbacks. Please refer below.
>
There is nothing wrong in this method as well except the guest DT needs to
be updated and that is bothersome.
Ofcourse if there is an option setting up the CNTFREQ directly is the option.
Regards,
Santosh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-18 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 16:47 [PATCH] ARM: dts: DRA7: provide arch-timer frequenecy parameter Nishanth Menon
2013-09-17 16:55 ` Santosh Shilimkar
2013-09-17 17:01 ` [PATCH V2] " Nishanth Menon
2013-09-18 11:33 ` Sricharan R
2013-09-18 13:02 ` Nishanth Menon
2013-09-18 13:23 ` Santosh Shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).