From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clockevents: Sanitize ticks to nsec conversion
Date: Wed, 18 Sep 2013 00:25:02 +0200 [thread overview]
Message-ID: <5238D6BE.6040603@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1309172228400.4089@ionos.tec.linutronix.de>
On 09/17/2013 11:15 PM, Thomas Gleixner wrote:
> Marc Kleine-Budde pointed out, that commit 77cc982 "clocksource: use
> clockevents_config_and_register() where possible" caused a regression
> for some of the converted subarchs.
>
> The reason is, that the clockevents core code converts the minimal
> hardware tick delta to a nanosecond value for core internal
> usage. This conversion is affected by integer math rounding loss, so
> the backwards conversion to hardware ticks will likely result in a
> value which is less than the configured hardware limitation. The
> affected subarchs used their own workaround (SIGH!) which got lost in
> the conversion.
>
> Now instead of fixing the underlying core code problem, Marcs patch
> tried to work around the core code issue by increasing the minimal
> tick delta at clockevents registration time so the resulting limit in
> the core code backwards conversion did not violate the hardware
> limits. More SIGH!
It was not easy getting your attention with this problem :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130918/6569f9f6/attachment.sig>
next prev parent reply other threads:[~2013-09-17 22:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 13:02 [PATCH] [PATCH] clocksource: tcb: fix min_delta calculation Marc Kleine-Budde
2013-09-17 9:56 ` Ludovic Desroches
2013-09-17 10:04 ` Russell King - ARM Linux
2013-09-17 11:26 ` Thomas Gleixner
2013-09-17 13:01 ` Ludovic Desroches
2013-09-17 21:15 ` [PATCH] clockevents: Sanitize ticks to nsec conversion Thomas Gleixner
2013-09-17 22:25 ` Marc Kleine-Budde [this message]
2013-09-17 23:20 ` Thomas Gleixner
2013-09-18 7:33 ` Ludovic Desroches
2013-09-18 8:56 ` Uwe Kleine-König
2013-09-18 9:38 ` Thomas Gleixner
2013-09-18 15:09 ` Uwe Kleine-König
2013-09-18 22:01 ` Thomas Gleixner
2013-09-19 10:02 ` Uwe Kleine-König
2013-09-19 10:15 ` Thomas Gleixner
2013-09-19 12:48 ` Uwe Kleine-König
2013-09-19 13:12 ` Thomas Gleixner
2013-09-19 14:30 ` Thomas Gleixner
2013-09-19 20:03 ` Uwe Kleine-König
2013-09-20 9:56 ` Thomas Gleixner
2013-09-20 20:41 ` Uwe Kleine-König
2013-09-20 21:30 ` Thomas Gleixner
2013-09-24 19:50 ` [PATCH v2] " Uwe Kleine-König
2013-09-24 21:11 ` Timekeeping on at91rm9200 [Was: [PATCH v2] clockevents: Sanitize ticks to nsec conversion] Uwe Kleine-König
2013-10-04 10:00 ` Nicolas Ferre
2013-09-24 21:16 ` [PATCH v2] clockevents: Sanitize ticks to nsec conversion Uwe Kleine-König
2013-10-08 10:08 ` Marc Kleine-Budde
2013-10-08 15:31 ` [GIT PULL] fixes for integer rounding in timer core (Was: [PATCH v2] clockevents: Sanitize ticks to nsec conversion) Uwe Kleine-König
2013-10-14 7:34 ` [GIT PULL] fixes for integer rounding in timer core Uwe Kleine-König
2013-10-16 14:19 ` Nicolas Ferre
2013-10-21 7:12 ` Uwe Kleine-König
2013-10-21 20:53 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5238D6BE.6040603@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).