linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH REPOST] ARM: tegra: use dt-binding header for key code
@ 2013-09-18 13:22 Laxman Dewangan
  2013-09-18 15:28 ` Stephen Warren
  2013-09-19 18:26 ` Stephen Warren
  0 siblings, 2 replies; 4+ messages in thread
From: Laxman Dewangan @ 2013-09-18 13:22 UTC (permalink / raw)
  To: linux-arm-kernel

In place of hardcoding the key code in DTS file and comment the
key code as side notes, use the key code macro defines in the
dt-bindings/input/input.h directly.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Reposting this patch as it was sent earlier when merge window was closed.

 arch/arm/boot/dts/tegra114-dalmore.dts |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index 6023028..05a3aae 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -1,5 +1,6 @@
 /dts-v1/;
 
+#include <dt-bindings/input/input.h>
 #include "tegra114.dtsi"
 
 / {
@@ -1081,26 +1082,26 @@
 		home {
 			label = "Home";
 			gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
-			linux,code = <102>; /* KEY_HOME */
+			linux,code = <KEY_HOME>;
 		};
 
 		power {
 			label = "Power";
 			gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
-			linux,code = <116>; /* KEY_POWER */
+			linux,code = <KEY_POWER>;
 			gpio-key,wakeup;
 		};
 
 		volume_down {
 			label = "Volume Down";
 			gpios = <&gpio TEGRA_GPIO(R, 1) GPIO_ACTIVE_LOW>;
-			linux,code = <114>; /* KEY_VOLUMEDOWN */
+			linux,code = <KEY_VOLUMEDOWN>;
 		};
 
 		volume_up {
 			label = "Volume Up";
 			gpios = <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_LOW>;
-			linux,code = <115>; /* KEY_VOLUMEUP */
+			linux,code = <KEY_VOLUMEUP>;
 		};
 	};
 
-- 
1.7.1.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH REPOST] ARM: tegra: use dt-binding header for key code
  2013-09-18 13:22 [PATCH REPOST] ARM: tegra: use dt-binding header for key code Laxman Dewangan
@ 2013-09-18 15:28 ` Stephen Warren
  2013-09-18 16:38   ` Laxman Dewangan
  2013-09-19 18:26 ` Stephen Warren
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2013-09-18 15:28 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/18/2013 07:22 AM, Laxman Dewangan wrote:
> In place of hardcoding the key code in DTS file and comment the
> key code as side notes, use the key code macro defines in the
> dt-bindings/input/input.h directly.

I can apply this, but aren't there many other Tegra DT files that need
conversion too?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH REPOST] ARM: tegra: use dt-binding header for key code
  2013-09-18 15:28 ` Stephen Warren
@ 2013-09-18 16:38   ` Laxman Dewangan
  0 siblings, 0 replies; 4+ messages in thread
From: Laxman Dewangan @ 2013-09-18 16:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 18 September 2013 08:58 PM, Stephen Warren wrote:
> On 09/18/2013 07:22 AM, Laxman Dewangan wrote:
>> In place of hardcoding the key code in DTS file and comment the
>> key code as side notes, use the key code macro defines in the
>> dt-bindings/input/input.h directly.
> I can apply this, but aren't there many other Tegra DT files that need
> conversion too?
Yes, I am planning to this in next few days. I will post different 
patches for different boards.
If it is fine to you, it can be applied this patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH REPOST] ARM: tegra: use dt-binding header for key code
  2013-09-18 13:22 [PATCH REPOST] ARM: tegra: use dt-binding header for key code Laxman Dewangan
  2013-09-18 15:28 ` Stephen Warren
@ 2013-09-19 18:26 ` Stephen Warren
  1 sibling, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2013-09-19 18:26 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/18/2013 07:22 AM, Laxman Dewangan wrote:
> In place of hardcoding the key code in DTS file and comment the
> key code as side notes, use the key code macro defines in the
> dt-bindings/input/input.h directly.

Applied to Tegra's for-3.13/dt branch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-19 18:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 13:22 [PATCH REPOST] ARM: tegra: use dt-binding header for key code Laxman Dewangan
2013-09-18 15:28 ` Stephen Warren
2013-09-18 16:38   ` Laxman Dewangan
2013-09-19 18:26 ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).