linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jiri.prchal@aksignal.cz (Jiří Prchal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91: mmc: fix missing pinctrl in dt
Date: Thu, 19 Sep 2013 15:24:54 +0200	[thread overview]
Message-ID: <523AFB26.9030701@aksignal.cz> (raw)
In-Reply-To: <523AFA48.80606@atmel.com>

OK.

Dne 19.9.2013 15:21, Nicolas Ferre napsal(a):
> On 17/09/2013 11:57, Jiri Prchal :
>> This patch adds pinctrl to soc dtsi file.
>>
>> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
>
>
> Jiri,
>
> I will rework your patch by splitting the two lines. This will allow us to be consistent with other AT91 SoC/boards
> Device Tree descriptions.
>
> +        pinctrl-names = "default";
>
> This one is going in the SoC file, like you did.
>
> +        pinctrl-0 = <&pinctrl_mmc0_slot0_clk_cmd_dat0>;
>
> This one is under the responsibility of the board itself. The reason behind this is that the dat0 line can be
> multiplexed on another pin.
>
> So, if you need a particular pinctrl configuration on the board side, please send another patch for this addition.
>
> Thanks bye,
>
>
>> ---
>>   arch/arm/boot/dts/at91sam9x5.dtsi |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index cf78ac0..c5d26b0 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -556,6 +556,8 @@
>>                   interrupts = <12 IRQ_TYPE_LEVEL_HIGH 0>;
>>                   dmas = <&dma0 1 AT91_DMA_CFG_PER_ID(0)>;
>>                   dma-names = "rxtx";
>> +                pinctrl-names = "default";
>> +                pinctrl-0 = <&pinctrl_mmc0_slot0_clk_cmd_dat0>;
>>                   #address-cells = <1>;
>>                   #size-cells = <0>;
>>                   status = "disabled";
>>
>
>

      reply	other threads:[~2013-09-19 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  9:57 [PATCH] at91: mmc: fix minimum bus frequency Jiri Prchal
2013-09-17  9:57 ` [PATCH] at91: mmc: fix missing pinctrl in dt Jiri Prchal
2013-09-19 13:21   ` Nicolas Ferre
2013-09-19 13:24     ` Jiří Prchal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523AFB26.9030701@aksignal.cz \
    --to=jiri.prchal@aksignal.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).