From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Mon, 23 Sep 2013 14:30:48 +0200 Subject: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask() In-Reply-To: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Message-ID: <52403478.6010305@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20/09/2013 00:01, Russell King : > The correct way for a driver to specify the coherent DMA mask is > not to directly access the field in the struct device, but to use > dma_set_coherent_mask(). Only arch and bus code should access this > member directly. > > Convert all direct write accesses to using the correct API. > > Signed-off-by: Russell King > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++-- > drivers/usb/dwc3/dwc3-exynos.c | 5 +++-- > drivers/usb/gadget/lpc32xx_udc.c | 4 +++- > drivers/usb/host/ehci-atmel.c | 5 +++-- For Atmel driver: Acked-by: Nicolas Ferre [..] > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index 3b645ff..5831a88 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -92,8 +92,9 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > */ > if (!pdev->dev.dma_mask) > pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; > - if (!pdev->dev.coherent_dma_mask) > - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); > + retval = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); > + if (retval) > + goto fail_create_hcd; > > hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev)); > if (!hcd) { [..] Thanks, -- Nicolas Ferre