* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
@ 2013-09-20 17:38 Balaji T K
2013-09-20 17:44 ` Felipe Balbi
2013-09-20 19:11 ` Nishanth Menon
0 siblings, 2 replies; 5+ messages in thread
From: Balaji T K @ 2013-09-20 17:38 UTC (permalink / raw)
To: linux-arm-kernel
correct mux mode for mmc1_cmd to detect eMMC on bone-black
Signed-off-by: Balaji T K <balajitk@ti.com>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 56361ce..90ab56c 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -117,7 +117,7 @@
emmc_pins: pinmux_emmc_pins {
pinctrl-single,pins = <
0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
- 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
+ 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
2013-09-20 17:38 [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd Balaji T K
@ 2013-09-20 17:44 ` Felipe Balbi
2013-09-20 19:11 ` Nishanth Menon
1 sibling, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2013-09-20 17:44 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 20, 2013 at 11:08:16PM +0530, Balaji T K wrote:
> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>
> Signed-off-by: Balaji T K <balajitk@ti.com>
Tested on my BBB, I see that after this patch eMMC gets detected just
fine:
Tested-by: Felipe Balbi <balbi@ti.com>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130920/bc24bfdb/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
2013-09-20 17:38 [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd Balaji T K
2013-09-20 17:44 ` Felipe Balbi
@ 2013-09-20 19:11 ` Nishanth Menon
2013-09-23 15:28 ` Balaji T K
1 sibling, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2013-09-20 19:11 UTC (permalink / raw)
To: linux-arm-kernel
On 09/20/2013 12:38 PM, Balaji T K wrote:
> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>
> Signed-off-by: Balaji T K <balajitk@ti.com>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 56361ce..90ab56c 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -117,7 +117,7 @@
> emmc_pins: pinmux_emmc_pins {
> pinctrl-single,pins = <
> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
>
is'nt this a common change? why is it "black only"? if it is so, then
the pinmux should probably be spun off outside bone-common.dtsi into
boneblack.dtsi perhaps?
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
2013-09-20 19:11 ` Nishanth Menon
@ 2013-09-23 15:28 ` Balaji T K
2013-09-24 2:24 ` Nishanth Menon
0 siblings, 1 reply; 5+ messages in thread
From: Balaji T K @ 2013-09-23 15:28 UTC (permalink / raw)
To: linux-arm-kernel
On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote:
> On 09/20/2013 12:38 PM, Balaji T K wrote:
>> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>>
>> Signed-off-by: Balaji T K <balajitk@ti.com>
>> ---
>> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> index 56361ce..90ab56c 100644
>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>> @@ -117,7 +117,7 @@
>> emmc_pins: pinmux_emmc_pins {
>> pinctrl-single,pins = <
>> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn1.mmc1_clk */
>> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_csn2.mmc1_cmd */
>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /* gpmc_csn2.mmc1_cmd */
>> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad0.mmc1_dat0 */
>> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad1.mmc1_dat1 */
>> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /* gpmc_ad2.mmc1_dat2 */
>>
> is'nt this a common change? why is it "black only"? if it is so, then
> the pinmux should probably be spun off outside bone-common.dtsi into
> boneblack.dtsi perhaps?
>
It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux can
remain in bone-common.dtsi.
However I could test only on beagle bone black which has eMMC on board, since I
don't have access to eMMC-cape
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd
2013-09-23 15:28 ` Balaji T K
@ 2013-09-24 2:24 ` Nishanth Menon
0 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2013-09-24 2:24 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 23, 2013 at 10:28 AM, Balaji T K <balajitk@ti.com> wrote:
> On Saturday 21 September 2013 12:41 AM, Nishanth Menon wrote:
>>
>> On 09/20/2013 12:38 PM, Balaji T K wrote:
>>>
>>> correct mux mode for mmc1_cmd to detect eMMC on bone-black
>>>
>>> Signed-off-by: Balaji T K <balajitk@ti.com>
>>> ---
>>> arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> index 56361ce..90ab56c 100644
>>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> @@ -117,7 +117,7 @@
>>> emmc_pins: pinmux_emmc_pins {
>>> pinctrl-single,pins = <
>>> 0x80 (PIN_INPUT_PULLUP | MUX_MODE2) /*
>>> gpmc_csn1.mmc1_clk */
>>> - 0x84 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_csn2.mmc1_cmd */
>>> + 0x84 (PIN_INPUT_PULLUP | MUX_MODE2) /*
>>> gpmc_csn2.mmc1_cmd */
>>> 0x00 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad0.mmc1_dat0 */
>>> 0x04 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad1.mmc1_dat1 */
>>> 0x08 (PIN_INPUT_PULLUP | MUX_MODE1) /*
>>> gpmc_ad2.mmc1_dat2 */
>>>
>> is'nt this a common change? why is it "black only"? if it is so, then
>> the pinmux should probably be spun off outside bone-common.dtsi into
>> boneblack.dtsi perhaps?
>>
>
> It is applicable for add-on eMMC-cape for beagle bone white, so eMMC pinmux
> can
> remain in bone-common.dtsi.
> However I could test only on beagle bone black which has eMMC on board,
> since I
> don't have access to eMMC-cape
Could you update the patch to the effect please considering you are
modifying am335x-bone-common.dtsi
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-24 2:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 17:38 [PATCH 1/1] ARM: dts: am335x-bone-common: correct mux mode for mmc1_cmd Balaji T K
2013-09-20 17:44 ` Felipe Balbi
2013-09-20 19:11 ` Nishanth Menon
2013-09-23 15:28 ` Balaji T K
2013-09-24 2:24 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).