From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB0BC761AE for ; Thu, 29 Aug 2024 06:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/FIVVve4R6A0vQ2I5fuTw1fYj0+2GlE50oNkZyDpx44=; b=ItwfFZSHIOfPWnS1ztvvzEUJKf jaohbWLoiV72Zmz/beZGWuC3j4fUAcnpEr02keQZtz6lybeBeLu8lt8vnHJaozK5gTWby4g+zj3OH RCSl+9vBD7V2J/XG+iCQhPdPEe24SR1tlDPmntff5fYt6AENO1EBmEzVlSwDnOFruImgdB74Sq8Z9 IIBW2eM988kLifM01v6UDZEzxecx125Gpb+ZbF6j8bZSHbwEt8INNXCP46mMr9kGKIKbIG5ENoWk5 s2/0lZw94id5zhXK89W5URdk847REa/hFV4yc2EkkVOY1wXggIlxPXMWXoPd15UVVrG/Sg5vwAhM1 /3slz6RA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYmU-00000000o52-1klS; Thu, 29 Aug 2024 06:37:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYbz-00000000l99-17if for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 06:26:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC3FADA7; Wed, 28 Aug 2024 23:26:48 -0700 (PDT) Received: from [10.162.41.23] (e116581.arm.com [10.162.41.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2783E3F66E; Wed, 28 Aug 2024 23:26:18 -0700 (PDT) Message-ID: <5241c418-d5af-46ca-8188-7b67e1640f88@arm.com> Date: Thu, 29 Aug 2024 11:55:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi To: Mark Brown Cc: shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, Anshuman.Khandual@arm.com, aneesh.kumar@kernel.org, linux-kernel@vger.kernel.org References: <20240827051851.3738533-1-dev.jain@arm.com> <6e5588d9-c22c-4a94-afce-1274c888403e@sirena.org.uk> Content-Language: en-US From: Dev Jain In-Reply-To: <6e5588d9-c22c-4a94-afce-1274c888403e@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_232627_392325_AFE3CCE3 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/28/24 16:10, Mark Brown wrote: > On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote: > >> - ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno)); >> + ksft_exit_fail_perror("PTRACE_TRACEME"); >> >> if (raise(SIGSTOP)) >> - ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno)); >> + ksft_exit_fail_perror("raise(SIGSTOP)"); > The idea with these is to include the error code as well so adding the > %s would be better. ksft_exit_fail_perror() can do that thing for us. > >> for (i = 9; i < ARRAY_SIZE(gpr_in); i++) { >> if (gpr_in[i] != gpr_out[i]) { >> - ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %llx != %llx\n", >> + ksft_print_msg("%s SVE VL %d mismatch in GPR %d: %lx != %lx\n", >> cfg->name, sve_vl, i, >> gpr_in[i], gpr_out[i]); >> errors++; > This is a different pattern of warning, it'd be easier to review if each > patch only followed one pattern. There's no code overlap between the > changes.