* [PATCH v2 1/4] ARM: shmobile: r8a7778: add Ether DT support
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
@ 2013-09-07 0:26 ` Sergei Shtylyov
2013-09-07 0:27 ` [PATCH v2 2/4] ARM: shmobile: r8a7778: add Ether clock for DT case Sergei Shtylyov
` (3 subsequent siblings)
4 siblings, 0 replies; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-07 0:26 UTC (permalink / raw)
To: linux-arm-kernel
Define the generic R8A7778 part of the Ether device node.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- changed the "compatible" property to "renesas,ether-r8a7778".
arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: renesas/arch/arm/boot/dts/r8a7778.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi
+++ renesas/arch/arm/boot/dts/r8a7778.dtsi
@@ -98,4 +98,15 @@
reg = <0xfffc000 0x118>;
#gpio-range-cells = <3>;
};
+
+ ether: ethernet at fde00000 {
+ device_type = "network";
+ compatible = "renesas,ether-r8a7778";
+ reg = <0xfde00000 0x400>;
+ interrupt-parent = <&gic>;
+ interrupts = <0 105 0x4>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 2/4] ARM: shmobile: r8a7778: add Ether clock for DT case
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
2013-09-07 0:26 ` [PATCH v2 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
@ 2013-09-07 0:27 ` Sergei Shtylyov
2013-09-07 0:29 ` [PATCH v2 3/4] ARM: shmobile: bockw-reference: add Ether DT support Sergei Shtylyov
` (2 subsequent siblings)
4 siblings, 0 replies; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-07 0:27 UTC (permalink / raw)
To: linux-arm-kernel
Add extra Ether clock lookup entry in the device tree case.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- refreshed the patch.
arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
1 file changed, 1 insertion(+)
Index: renesas/arch/arm/mach-shmobile/clock-r8a7778.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/clock-r8a7778.c
+++ renesas/arch/arm/mach-shmobile/clock-r8a7778.c
@@ -174,6 +174,7 @@ static struct clk_lookup lookups[] = {
CLKDEV_DEV_ID("sh_mobile_sdhi.1", &mstp_clks[MSTP322]), /* SDHI1 */
CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP321]), /* SDHI2 */
CLKDEV_DEV_ID("r8a777x-ether", &mstp_clks[MSTP114]), /* Ether */
+ CLKDEV_DEV_ID("fde00000.ethernet", &mstp_clks[MSTP114]), /* Ether w/DT */
CLKDEV_DEV_ID("ehci-platform", &mstp_clks[MSTP100]), /* USB EHCI port0/1 */
CLKDEV_DEV_ID("ohci-platform", &mstp_clks[MSTP100]), /* USB OHCI port0/1 */
CLKDEV_DEV_ID("renesas_usbhs", &mstp_clks[MSTP100]), /* USB FUNC */
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 3/4] ARM: shmobile: bockw-reference: add Ether DT support
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
2013-09-07 0:26 ` [PATCH v2 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-07 0:27 ` [PATCH v2 2/4] ARM: shmobile: r8a7778: add Ether clock for DT case Sergei Shtylyov
@ 2013-09-07 0:29 ` Sergei Shtylyov
2013-09-07 0:31 ` [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings Sergei Shtylyov
2013-09-09 0:11 ` [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Simon Horman
4 siblings, 0 replies; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-07 0:29 UTC (permalink / raw)
To: linux-arm-kernel
Define the BOCK-W board dependent part of the Ether device node.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/boot/dts/r8a7778-bockw-reference.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
Index: renesas/arch/arm/boot/dts/r8a7778-bockw-reference.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7778-bockw-reference.dts
+++ renesas/arch/arm/boot/dts/r8a7778-bockw-reference.dts
@@ -30,3 +30,14 @@
reg = <0x60000000 0x10000000>;
};
};
+
+ðer {
+ status = "ok";
+ phy-mode = "rmii";
+ phy-handle = <&phy1>;
+ renesas,no-ether-link;
+
+ phy1: ethernet-phy at 1 {
+ reg = <1>;
+ };
+};
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
` (2 preceding siblings ...)
2013-09-07 0:29 ` [PATCH v2 3/4] ARM: shmobile: bockw-reference: add Ether DT support Sergei Shtylyov
@ 2013-09-07 0:31 ` Sergei Shtylyov
2013-09-09 7:05 ` Magnus Damm
2013-09-09 0:11 ` [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Simon Horman
4 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-07 0:31 UTC (permalink / raw)
To: linux-arm-kernel
Add the Ether pin group to bockw_pinctrl_map[].
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
1 file changed, 3 insertions(+)
Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
@@ -29,6 +29,9 @@
*/
static const struct pinctrl_map bockw_pinctrl_map[] = {
+ /* Ether */
+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
+ "ether_rmii", "ether"),
/* SCIF0 */
PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
"scif0_data_a", "scif0"),
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-07 0:31 ` [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings Sergei Shtylyov
@ 2013-09-09 7:05 ` Magnus Damm
2013-09-11 12:14 ` Sergei Shtylyov
0 siblings, 1 reply; 17+ messages in thread
From: Magnus Damm @ 2013-09-09 7:05 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 7, 2013 at 9:31 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add the Ether pin group to bockw_pinctrl_map[].
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> ===================================================================
> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> @@ -29,6 +29,9 @@
> */
>
> static const struct pinctrl_map bockw_pinctrl_map[] = {
> + /* Ether */
> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> + "ether_rmii", "ether"),
> /* SCIF0 */
> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> "scif0_data_a", "scif0"),
Hi Sergei,
Thanks for your patches. In general I think your series looks fine. I
have a single comment, and that's about the pinctrl-related hunk
above. I can see that this patch is for DT reference for Bock-W, so I
expect the code to be in DT. Do you have any plans to use DT to
describe the pinmux bits? Perhaps you have some incremental patch
planned?
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-09 7:05 ` Magnus Damm
@ 2013-09-11 12:14 ` Sergei Shtylyov
2013-09-25 4:47 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-11 12:14 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09-09-2013 11:05, Magnus Damm wrote:
>> Add the Ether pin group to bockw_pinctrl_map[].
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>> ===================================================================
>> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
>> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>> @@ -29,6 +29,9 @@
>> */
>>
>> static const struct pinctrl_map bockw_pinctrl_map[] = {
>> + /* Ether */
>> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
>> + "ether_rmii", "ether"),
>> /* SCIF0 */
>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>> "scif0_data_a", "scif0"),
> Hi Sergei,
> Thanks for your patches. In general I think your series looks fine. I
> have a single comment, and that's about the pinctrl-related hunk
> above. I can see that this patch is for DT reference for Bock-W, so I
> expect the code to be in DT. Do you have any plans to use DT to
> describe the pinmux bits? Perhaps you have some incremental patch
> planned?
No, I just repeated what I saw mechanically. Now I'm seeing some evidence
that PFC driver supports the device tree, so I probably need to redo the
patchset... let me study this question better.
> Cheers,
> / magnus
WBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-11 12:14 ` Sergei Shtylyov
@ 2013-09-25 4:47 ` Simon Horman
2013-09-25 15:54 ` Sergei Shtylyov
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-09-25 4:47 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 11, 2013 at 04:14:28PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09-09-2013 11:05, Magnus Damm wrote:
>
> >>Add the Ether pin group to bockw_pinctrl_map[].
>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>---
> >> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >>Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>===================================================================
> >>--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> >>+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>@@ -29,6 +29,9 @@
> >> */
> >>
> >> static const struct pinctrl_map bockw_pinctrl_map[] = {
> >>+ /* Ether */
> >>+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> >>+ "ether_rmii", "ether"),
> >> /* SCIF0 */
> >> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> >> "scif0_data_a", "scif0"),
>
> >Hi Sergei,
>
> >Thanks for your patches. In general I think your series looks fine. I
> >have a single comment, and that's about the pinctrl-related hunk
> >above. I can see that this patch is for DT reference for Bock-W, so I
> >expect the code to be in DT. Do you have any plans to use DT to
> >describe the pinmux bits? Perhaps you have some incremental patch
> >planned?
>
> No, I just repeated what I saw mechanically. Now I'm seeing some
> evidence that PFC driver supports the device tree, so I probably
> need to redo the patchset... let me study this question better.
Ping.
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-25 4:47 ` Simon Horman
@ 2013-09-25 15:54 ` Sergei Shtylyov
2013-09-26 1:51 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-25 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09/25/2013 08:47 AM, Simon Horman wrote:
>>>> Add the Ether pin group to bockw_pinctrl_map[].
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> ---
>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>> ===================================================================
>>>> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
>>>> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>> @@ -29,6 +29,9 @@
>>>> */
>>>>
>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
>>>> + /* Ether */
>>>> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
>>>> + "ether_rmii", "ether"),
>>>> /* SCIF0 */
>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>>>> "scif0_data_a", "scif0"),
>>> Hi Sergei,
>>> Thanks for your patches. In general I think your series looks fine. I
>>> have a single comment, and that's about the pinctrl-related hunk
>>> above. I can see that this patch is for DT reference for Bock-W, so I
>>> expect the code to be in DT. Do you have any plans to use DT to
>>> describe the pinmux bits? Perhaps you have some incremental patch
>>> planned?
>> No, I just repeated what I saw mechanically. Now I'm seeing some
>> evidence that PFC driver supports the device tree, so I probably
>> need to redo the patchset... let me study this question better.
> Ping.
Sorry, I got distracted by other work and didn't advance much here.
Will try to respin the patchset before my vacation (next Monday). Although the
driver DT support patch have seemingly stalemated due to the most recent
comments...
WBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-25 15:54 ` Sergei Shtylyov
@ 2013-09-26 1:51 ` Simon Horman
2013-09-26 20:44 ` Sergei Shtylyov
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-09-26 1:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 25, 2013 at 07:54:36PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09/25/2013 08:47 AM, Simon Horman wrote:
>
> >>>>Add the Ether pin group to bockw_pinctrl_map[].
>
> >>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>>>---
> >>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> >>>> 1 file changed, 3 insertions(+)
>
> >>>>Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>===================================================================
> >>>>--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>@@ -29,6 +29,9 @@
> >>>> */
> >>>>
> >>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
> >>>>+ /* Ether */
> >>>>+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> >>>>+ "ether_rmii", "ether"),
> >>>> /* SCIF0 */
> >>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> >>>> "scif0_data_a", "scif0"),
>
> >>>Hi Sergei,
>
> >>>Thanks for your patches. In general I think your series looks fine. I
> >>>have a single comment, and that's about the pinctrl-related hunk
> >>>above. I can see that this patch is for DT reference for Bock-W, so I
> >>>expect the code to be in DT. Do you have any plans to use DT to
> >>>describe the pinmux bits? Perhaps you have some incremental patch
> >>>planned?
>
> >> No, I just repeated what I saw mechanically. Now I'm seeing some
> >>evidence that PFC driver supports the device tree, so I probably
> >>need to redo the patchset... let me study this question better.
>
> >Ping.
>
> Sorry, I got distracted by other work and didn't advance much here.
> Will try to respin the patchset before my vacation (next Monday).
> Although the driver DT support patch have seemingly stalemated due
> to the most recent comments...
Thanks for the update.
I guess the key is to move forward on the driver side, somehow.
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-26 1:51 ` Simon Horman
@ 2013-09-26 20:44 ` Sergei Shtylyov
2013-09-27 4:38 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2013-09-26 20:44 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09/26/2013 05:51 AM, Simon Horman wrote:
>>>>>> Add the Ether pin group to bockw_pinctrl_map[].
>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>>> ---
>>>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
>>>>>> 1 file changed, 3 insertions(+)
>>>>>> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>> ===================================================================
>>>>>> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>> @@ -29,6 +29,9 @@
>>>>>> */
>>>>>>
>>>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
>>>>>> + /* Ether */
>>>>>> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
>>>>>> + "ether_rmii", "ether"),
>>>>>> /* SCIF0 */
>>>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>>>>>> "scif0_data_a", "scif0"),
>>>>> Hi Sergei,
>>>>> Thanks for your patches. In general I think your series looks fine. I
>>>>> have a single comment, and that's about the pinctrl-related hunk
>>>>> above. I can see that this patch is for DT reference for Bock-W, so I
>>>>> expect the code to be in DT. Do you have any plans to use DT to
>>>>> describe the pinmux bits? Perhaps you have some incremental patch
>>>>> planned?
>>>> No, I just repeated what I saw mechanically. Now I'm seeing some
>>>> evidence that PFC driver supports the device tree, so I probably
>>>> need to redo the patchset... let me study this question better.
>>> Ping.
>> Sorry, I got distracted by other work and didn't advance much here.
>> Will try to respin the patchset before my vacation (next Monday).
>> Although the driver DT support patch have seemingly stalemated due
>> to the most recent comments...
> Thanks for the update.
> I guess the key is to move forward on the driver side, somehow.
Do you mean we should grant Stephen's requests concerning clock DT support
before we add the DT support to the driver?
WBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-26 20:44 ` Sergei Shtylyov
@ 2013-09-27 4:38 ` Simon Horman
2013-10-16 21:56 ` Sergei Shtylyov
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-09-27 4:38 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 27, 2013 at 12:44:18AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09/26/2013 05:51 AM, Simon Horman wrote:
>
> >>>>>>Add the Ether pin group to bockw_pinctrl_map[].
>
> >>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>>>>>---
> >>>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> >>>>>> 1 file changed, 3 insertions(+)
>
> >>>>>>Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>===================================================================
> >>>>>>--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>@@ -29,6 +29,9 @@
> >>>>>> */
> >>>>>>
> >>>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
> >>>>>>+ /* Ether */
> >>>>>>+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> >>>>>>+ "ether_rmii", "ether"),
> >>>>>> /* SCIF0 */
> >>>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> >>>>>> "scif0_data_a", "scif0"),
>
> >>>>>Hi Sergei,
>
> >>>>>Thanks for your patches. In general I think your series looks fine. I
> >>>>>have a single comment, and that's about the pinctrl-related hunk
> >>>>>above. I can see that this patch is for DT reference for Bock-W, so I
> >>>>>expect the code to be in DT. Do you have any plans to use DT to
> >>>>>describe the pinmux bits? Perhaps you have some incremental patch
> >>>>>planned?
>
> >>>> No, I just repeated what I saw mechanically. Now I'm seeing some
> >>>>evidence that PFC driver supports the device tree, so I probably
> >>>>need to redo the patchset... let me study this question better.
>
> >>>Ping.
>
> >> Sorry, I got distracted by other work and didn't advance much here.
> >>Will try to respin the patchset before my vacation (next Monday).
> >>Although the driver DT support patch have seemingly stalemated due
> >>to the most recent comments...
>
> >Thanks for the update.
>
> >I guess the key is to move forward on the driver side, somehow.
>
> Do you mean we should grant Stephen's requests concerning clock
> DT support before we add the DT support to the driver?
That seems like the most logical way forwards to me.
Is the main issue that the clocks aren't accessible via DT at this time?
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-09-27 4:38 ` Simon Horman
@ 2013-10-16 21:56 ` Sergei Shtylyov
2013-10-17 6:06 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Sergei Shtylyov @ 2013-10-16 21:56 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09/27/2013 08:38 AM, Simon Horman wrote:
Sorry for the very late reply: I was busy with other stuff and then had ~2
weeks of vacations...
>>>>>>>> Add the Ether pin group to bockw_pinctrl_map[].
>>>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>>>>> ---
>>>>>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
>>>>>>>> 1 file changed, 3 insertions(+)
>>>>>>>> Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>>>> ===================================================================
>>>>>>>> --- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>>>> +++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
>>>>>>>> @@ -29,6 +29,9 @@
>>>>>>>> */
>>>>>>>>
>>>>>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
>>>>>>>> + /* Ether */
>>>>>>>> + PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
>>>>>>>> + "ether_rmii", "ether"),
>>>>>>>> /* SCIF0 */
>>>>>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
>>>>>>>> "scif0_data_a", "scif0"),
>>>>>>> Hi Sergei,
>>>>>>> Thanks for your patches. In general I think your series looks fine. I
>>>>>>> have a single comment, and that's about the pinctrl-related hunk
>>>>>>> above. I can see that this patch is for DT reference for Bock-W, so I
>>>>>>> expect the code to be in DT. Do you have any plans to use DT to
>>>>>>> describe the pinmux bits? Perhaps you have some incremental patch
>>>>>>> planned?
>>>>>> No, I just repeated what I saw mechanically. Now I'm seeing some
>>>>>> evidence that PFC driver supports the device tree, so I probably
>>>>>> need to redo the patchset... let me study this question better.
>>>>> Ping.
>>>> Sorry, I got distracted by other work and didn't advance much here.
>>>> Will try to respin the patchset before my vacation (next Monday).
>>>> Although the driver DT support patch have seemingly stalemated due
>>>> to the most recent comments...
>>> Thanks for the update.
>>> I guess the key is to move forward on the driver side, somehow.
>> Do you mean we should grant Stephen's requests concerning clock
>> DT support before we add the DT support to the driver?
> That seems like the most logical way forwards to me.
Why? Why R-Car I2C driver device tree support was accepted without this,
although the driver uses clocks directly? Why such discrimination is applied
only to the Ethernet driver?
> Is the main issue that the clocks aren't accessible via DT at this time?
In the eyes of Stephen, yes.
WBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-10-16 21:56 ` Sergei Shtylyov
@ 2013-10-17 6:06 ` Simon Horman
2013-10-17 6:07 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-10-17 6:06 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 17, 2013 at 01:56:26AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09/27/2013 08:38 AM, Simon Horman wrote:
>
> Sorry for the very late reply: I was busy with other stuff and
> then had ~2 weeks of vacations...
>
> >>>>>>>>Add the Ether pin group to bockw_pinctrl_map[].
>
> >>>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>>>>>>>---
> >>>>>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> >>>>>>>> 1 file changed, 3 insertions(+)
>
> >>>>>>>>Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>>>===================================================================
> >>>>>>>>--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>>>+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> >>>>>>>>@@ -29,6 +29,9 @@
> >>>>>>>> */
> >>>>>>>>
> >>>>>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
> >>>>>>>>+ /* Ether */
> >>>>>>>>+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> >>>>>>>>+ "ether_rmii", "ether"),
> >>>>>>>> /* SCIF0 */
> >>>>>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> >>>>>>>> "scif0_data_a", "scif0"),
>
> >>>>>>>Hi Sergei,
>
> >>>>>>>Thanks for your patches. In general I think your series looks fine. I
> >>>>>>>have a single comment, and that's about the pinctrl-related hunk
> >>>>>>>above. I can see that this patch is for DT reference for Bock-W, so I
> >>>>>>>expect the code to be in DT. Do you have any plans to use DT to
> >>>>>>>describe the pinmux bits? Perhaps you have some incremental patch
> >>>>>>>planned?
>
> >>>>>> No, I just repeated what I saw mechanically. Now I'm seeing some
> >>>>>>evidence that PFC driver supports the device tree, so I probably
> >>>>>>need to redo the patchset... let me study this question better.
>
> >>>>>Ping.
>
> >>>> Sorry, I got distracted by other work and didn't advance much here.
> >>>>Will try to respin the patchset before my vacation (next Monday).
> >>>>Although the driver DT support patch have seemingly stalemated due
> >>>>to the most recent comments...
>
> >>>Thanks for the update.
>
> >>>I guess the key is to move forward on the driver side, somehow.
>
> >> Do you mean we should grant Stephen's requests concerning clock
> >>DT support before we add the DT support to the driver?
>
> >That seems like the most logical way forwards to me.
>
> Why? Why R-Car I2C driver device tree support was accepted
> without this, although the driver uses clocks directly? Why such
> discrimination is applied only to the Ethernet driver?
That is a good point. Have you made it to Stephen.
My point was to point out where I feel the path of least resistance is
and thus a possible avenue for you to pursue. The exact path you take
to reach your goal isn't of particular interest to me. What is of interest
to me is that you get there somehow :)
> >Is the main issue that the clocks aren't accessible via DT at this time?
>
> In the eyes of Stephen, yes.
Thanks, to be honest I was not entirely clear about this.
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
2013-10-17 6:06 ` Simon Horman
@ 2013-10-17 6:07 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2013-10-17 6:07 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 17, 2013 at 03:06:12PM +0900, Simon Horman wrote:
> On Thu, Oct 17, 2013 at 01:56:26AM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 09/27/2013 08:38 AM, Simon Horman wrote:
> >
> > Sorry for the very late reply: I was busy with other stuff and
> > then had ~2 weeks of vacations...
> >
> > >>>>>>>>Add the Ether pin group to bockw_pinctrl_map[].
> >
> > >>>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > >>>>>>>>---
> > >>>>>>>> arch/arm/mach-shmobile/board-bockw-reference.c | 3 +++
> > >>>>>>>> 1 file changed, 3 insertions(+)
> >
> > >>>>>>>>Index: renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> > >>>>>>>>===================================================================
> > >>>>>>>>--- renesas.orig/arch/arm/mach-shmobile/board-bockw-reference.c
> > >>>>>>>>+++ renesas/arch/arm/mach-shmobile/board-bockw-reference.c
> > >>>>>>>>@@ -29,6 +29,9 @@
> > >>>>>>>> */
> > >>>>>>>>
> > >>>>>>>> static const struct pinctrl_map bockw_pinctrl_map[] = {
> > >>>>>>>>+ /* Ether */
> > >>>>>>>>+ PIN_MAP_MUX_GROUP_DEFAULT("fde00000.ethernet", "pfc-r8a7778",
> > >>>>>>>>+ "ether_rmii", "ether"),
> > >>>>>>>> /* SCIF0 */
> > >>>>>>>> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a7778",
> > >>>>>>>> "scif0_data_a", "scif0"),
> >
> > >>>>>>>Hi Sergei,
> >
> > >>>>>>>Thanks for your patches. In general I think your series looks fine. I
> > >>>>>>>have a single comment, and that's about the pinctrl-related hunk
> > >>>>>>>above. I can see that this patch is for DT reference for Bock-W, so I
> > >>>>>>>expect the code to be in DT. Do you have any plans to use DT to
> > >>>>>>>describe the pinmux bits? Perhaps you have some incremental patch
> > >>>>>>>planned?
> >
> > >>>>>> No, I just repeated what I saw mechanically. Now I'm seeing some
> > >>>>>>evidence that PFC driver supports the device tree, so I probably
> > >>>>>>need to redo the patchset... let me study this question better.
> >
> > >>>>>Ping.
> >
> > >>>> Sorry, I got distracted by other work and didn't advance much here.
> > >>>>Will try to respin the patchset before my vacation (next Monday).
> > >>>>Although the driver DT support patch have seemingly stalemated due
> > >>>>to the most recent comments...
> >
> > >>>Thanks for the update.
> >
> > >>>I guess the key is to move forward on the driver side, somehow.
> >
> > >> Do you mean we should grant Stephen's requests concerning clock
> > >>DT support before we add the DT support to the driver?
> >
> > >That seems like the most logical way forwards to me.
> >
> > Why? Why R-Car I2C driver device tree support was accepted
> > without this, although the driver uses clocks directly? Why such
> > discrimination is applied only to the Ethernet driver?
>
> That is a good point. Have you made it to Stephen.
I see in the next email in my inbox that you now have.
Thanks.
>
> My point was to point out where I feel the path of least resistance is
> and thus a possible avenue for you to pursue. The exact path you take
> to reach your goal isn't of particular interest to me. What is of interest
> to me is that you get there somehow :)
>
> > >Is the main issue that the clocks aren't accessible via DT at this time?
> >
> > In the eyes of Stephen, yes.
>
> Thanks, to be honest I was not entirely clear about this.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board
2013-09-07 0:23 [PATCH v2 0/4] Add Ether DT support for R8A7778/BOCK-W reference board Sergei Shtylyov
` (3 preceding siblings ...)
2013-09-07 0:31 ` [PATCH v2 4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings Sergei Shtylyov
@ 2013-09-09 0:11 ` Simon Horman
2013-09-09 0:48 ` Kuninori Morimoto
4 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2013-09-09 0:11 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 07, 2013 at 04:23:29AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> Here's the set of 4 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-20130906' tag. Here we add the Ether device tree support working
> on the R8A7778/BOCK-W reference board. The patchset requires the 'sh_eth' driver
> device tree support posted earlier in order to work.
These patches seem fine to me.
Magnus, Morimoto-san, do you have any feedback?
Assuming that is a run-time dependency I think I can go ahead
and queue these up for v3.13 once they are reviewed.
>
> [1/4] ARM: shmobile: r8a7778: add Ether DT support
> [2/4] ARM: shmobile: r8a7778: add Ether clock for DT case
> [3/4] ARM: shmobile: bockw-reference: add Ether DT support
> [4/4] ARM: shmobile: BOCK-W reference: add Ether PFC settings
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 17+ messages in thread