From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: imprecise external abort using the flexcan driver on i.MX6Q
Date: Fri, 27 Sep 2013 16:35:29 +0200 [thread overview]
Message-ID: <524597B1.5070703@pengutronix.de> (raw)
In-Reply-To: <21061.38627.854812.311229@ipc1.ka-ro>
On 09/27/2013 04:32 PM, Lothar Wa?mann wrote:
> Hi,
>
> Fabio Estevam writes:
>> Hi Lothar,
>>
>> On Thu, Sep 26, 2013 at 11:01 AM, Lothar Wa?mann
>> <LW@karo-electronics.de> wrote:
>>> Does anyone have any clue how this can happen?
>>>
>>> Can anyone reproduce this on another machine?
>>
>> Is the change below needed?
>>
>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> @@ -310,7 +310,7 @@
>> };
>>
>> can1: flexcan at 02090000 {
>> - compatible = "fsl,imx6q-flexcan";
>> + compatible = "fsl,imx6q-flexcan",
>> "fsl,p1010-flexcan";
>> reg = <0x02090000 0x4000>;
>> interrupts = <0 110 0x04>;
>> clocks = <&clks 108>, <&clks 109>;
>> @@ -318,7 +318,7 @@
>> };
>>
>> can2: flexcan at 02094000 {
>> - compatible = "fsl,imx6q-flexcan";
>> + compatible = "fsl,imx6q-flexcan",
>> "fsl,p1010-flexcan";
>> reg = <0x02094000 0x4000>;
>> interrupts = <0 111 0x04>;
>> clocks = <&clks 110>, <&clks 111>;
> The driver contains:
> |static const struct of_device_id flexcan_of_match[] = {
> | { .compatible = "fsl,p1010-flexcan", .data = &fsl_p1010_devtype_data, },
> | { .compatible = "fsl,imx28-flexcan", .data = &fsl_imx28_devtype_data, },
> | { .compatible = "fsl,imx6q-flexcan", .data = &fsl_imx6q_devtype_data, },
> | { /* sentinel */ },
>
> Thus, with your proposed change the DT data would become ambiguous and
> the driver might use &fsl_p1010_devtype_data rather than
> &fsl_imx6q_devtype_data depending how the matching algorithm works.
In fact the imx6 flexcan is not compatible with the p1010, as a certain
register on the imx6 must be written to let the driver work.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130927/caf8911a/attachment.sig>
next prev parent reply other threads:[~2013-09-27 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:01 imprecise external abort using the flexcan driver on i.MX6Q =?utf-8?Q?Lothar_Wa=C3=9Fmann?=
2013-09-26 15:22 ` Fabio Estevam
2013-09-26 15:26 ` Fabio Estevam
2013-09-27 14:32 ` Lothar Waßmann
2013-09-27 14:35 ` Marc Kleine-Budde [this message]
2013-09-26 15:42 ` Marc Kleine-Budde
2013-09-26 15:54 ` Russell King - ARM Linux
2013-09-26 16:24 ` Santosh Shilimkar
2013-09-27 9:23 ` Lothar Waßmann
2013-09-27 9:43 ` Marc Kleine-Budde
2013-09-27 10:04 ` Lothar Waßmann
2013-09-27 10:14 ` Marc Kleine-Budde
2013-09-27 10:43 ` Lothar Waßmann
2013-09-26 19:04 ` Matt Sealey
2013-09-27 9:41 ` Lothar Waßmann
2013-09-27 17:24 ` Matt Sealey
2013-09-27 19:55 ` Marc Kleine-Budde
2013-09-30 11:06 ` Lothar Waßmann
2013-09-30 11:19 ` Marc Kleine-Budde
2013-09-30 11:37 ` Lothar Waßmann
2013-09-30 11:39 ` Marc Kleine-Budde
2013-09-27 8:59 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524597B1.5070703@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).