linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data
Date: Mon, 30 Sep 2013 17:44:12 +0530	[thread overview]
Message-ID: <52496B14.9090902@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309301025500.17980@utopia.booyaka.com>

Hi Paul,

On Monday 30 September 2013 03:57 PM, Paul Walmsley wrote:
> On Thu, 26 Sep 2013, Afzal Mohammed wrote:

>> From: Ambresh K <ambresh@ti.com>
>>
>> Add the data file to describe all power domains in AM43x SoC.
>> OMAP4 powerdomain operations is being reused here.
>>
>> Signed-off-by: Ambresh K <ambresh@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> 
> ...
> 
>> --- /dev/null
>> +++ b/arch/arm/mach-omap2/powerdomains43xx_data.c
>> @@ -0,0 +1,142 @@
> 
> ...
> 
>> +static struct powerdomain per_43xx_pwrdm = {
>> +	.name		  = "per_pwrdm",
>> +	.voltdm		  = { .name = "core" },
>> +	.prcm_offs	  = AM43XX_PRM_PER_INST,
>> +	.prcm_partition	  = AM43XX_PRM_PARTITION,
>> +	.pwrsts		  = PWRSTS_OFF_RET_ON,
>> +	.pwrsts_logic_ret = PWRSTS_OFF_RET,
>> +	.banks		  = 4,
>> +	.pwrsts_mem_ret	= {
>> +		[0] = PWRSTS_OFF_RET,	/* icss_mem */
>> +		[1] = PWRSTS_OFF_RET,	/* per_mem */
>> +		[2] = PWRSTS_OFF_RET,	/* ram1_mem */
>> +		[3] = PWRSTS_OFF_RET,	/* ram2_mem */
>> +	},
>> +	.pwrsts_mem_on	= {
>> +		[0] = PWRSTS_OFF_RET,	/* icss_mem */
>> +		[1] = PWRSTS_ON,	/* per_mem */
>> +		[2] = PWRSTS_OFF_RET,	/* ram1_mem */
>> +		[3] = PWRSTS_OFF_RET,	/* ram2_mem */
>> +	},
>> +	.flags		  = PWRDM_HAS_LOWPOWERSTATECHANGE,
>> +};
> 
> The pwrsts_mem_on flags don't make any sense here for banks 0, 2, and 3.  
> They claim that those banks can never be turned on.  Could you please 
> doublecheck these?

Checked it, they should be PWRSTS_ON, I will fix it.

Regards
Afzal

  reply	other threads:[~2013-09-30 12:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  9:28 [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 01/11] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-09-30  3:23   ` Paul Walmsley
2013-09-30  8:50     ` Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 03/11] ARM: OMAP2+: hwmod: AM335x: runtime register update Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 04/11] ARM: OMAP2+: hwmod: AM335x: remove static register offs Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 05/11] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-09-30 10:27   ` Paul Walmsley
2013-09-30 12:14     ` Afzal Mohammed [this message]
2013-09-26  9:33 ` [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-09-30  9:31   ` Paul Walmsley
2013-09-30 10:16     ` Paul Walmsley
2013-09-30 11:05     ` Afzal Mohammed
2013-09-30 11:09       ` Paul Walmsley
2013-09-30 11:38         ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 08/11] ARM: OMAP2+: hwmod: AM43x support Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 09/11] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 10/11] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 11/11] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-09-26 10:30 ` [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52496B14.9090902@ti.com \
    --to=afzal@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).