From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag
Date: Mon, 30 Sep 2013 17:48:54 +0200 [thread overview]
Message-ID: <52499D66.9070203@atmel.com> (raw)
In-Reply-To: <4748525.slmbI8ubRr@amdc1032>
On 30/09/2013 17:38, Bartlomiej Zolnierkiewicz :
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
Yes, okay. But please do not mix the removal of white lines with your
modification.
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Anyway, no need to resend it:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> v2:
> - use __initdata as it is OK to do it
>
> arch/arm/mach-at91/board-cam60.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-cam60.c b/arch/arm/mach-at91/board-cam60.c
> index ade948b..ecabbed 100644
> --- a/arch/arm/mach-at91/board-cam60.c
> +++ b/arch/arm/mach-at91/board-cam60.c
> @@ -108,16 +108,14 @@ static struct spi_board_info cam60_spi_devices[] __initdata = {
> #endif
> };
>
> -
> /*
> * MACB Ethernet device
> */
> -static struct __initdata macb_platform_data cam60_macb_data = {
> +static struct macb_platform_data cam60_macb_data __initdata = {
> .phy_irq_pin = AT91_PIN_PB5,
> .is_rmii = 0,
> };
>
> -
> /*
> * NAND Flash
> */
>
--
Nicolas Ferre
prev parent reply other threads:[~2013-09-30 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 15:38 [PATCH v2] ARM: at91: cam60: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-09-30 15:48 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52499D66.9070203@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox