linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 3/3] Enable BCM2835 mailbox support
Date: Tue, 01 Oct 2013 21:15:20 -0600	[thread overview]
Message-ID: <524B8FC8.20603@wwwdotorg.org> (raw)
In-Reply-To: <5232F7D8.6080307@yahoo.com.au>

On 09/13/2013 05:32 AM, Craig McGeachie wrote:
> Implement BCM2835 CPU thermal sensor support.
> 
> Signed-off-by: Craig McGeachie <slapdau@yahoo.com.au>
> ---
> 
> Beyond the usual reviews of rubbish code, there are two points
> here that I'm looking for feedback on.
> 
> First is the placement of the mailbox directory make target in
> drivers/Makefile.  I placed it as early as I did in anticipation of
> implemented a frame buffer driver, which needs mailbox support at
> probe time. Another option would be to initialise the driver at
> architecture initialisation time, but I'm unfamiliar with good
> practice about when to initialise different bits and pieces.
> Especially with generic mailbox support looking kinda new.

These days, all drivers should support deferred probe, so that if they
get probe()d and find that resources they need aren't yet available,
they return -EPROBE_DEFER from probe(), and the driver core will call
their probe() again later, when hopefully the resources actually will be
available. Once this works, most drivers will simply use
module_initcall(). This all avoids having to play games with link order
or initcall ordering.

  reply	other threads:[~2013-10-02  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 11:32 [RFC PATCH 3/3] Enable BCM2835 mailbox support Craig McGeachie
2013-10-02  3:15 ` Stephen Warren [this message]
2013-10-02  9:16   ` Craig McGeachie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524B8FC8.20603@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).