* [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
@ 2013-10-04 10:21 Jean-Francois Moine
2013-10-04 10:22 ` Sebastian Hesselbarth
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Francois Moine @ 2013-10-04 10:21 UTC (permalink / raw)
To: linux-arm-kernel
As defined in the DT, clkout2 is not allowed to change the pll inside
si5351.
This patch inverts the properties of the clkout{1,2} so that clkout2
may be defined as the external clock of the audio device in the Cubox.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
arch/arm/boot/dts/dove-cubox.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
index 022646e..5d1ece1 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -101,16 +101,16 @@
clkout1 {
reg = <1>;
- silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
- silabs,pll-master;
};
clkout2 {
reg = <2>;
+ silabs,drive-strength = <8>;
silabs,multisynth-source = <1>;
silabs,clock-source = <0>;
+ silabs,pll-master;
};
};
};
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio
2013-10-04 10:21 [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio Jean-Francois Moine
@ 2013-10-04 10:22 ` Sebastian Hesselbarth
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Hesselbarth @ 2013-10-04 10:22 UTC (permalink / raw)
To: linux-arm-kernel
On 10/04/2013 12:21 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch inverts the properties of the clkout{1,2} so that clkout2
> may be defined as the external clock of the audio device in the Cubox.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
> arch/arm/boot/dts/dove-cubox.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index 022646e..5d1ece1 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -101,16 +101,16 @@
>
> clkout1 {
> reg = <1>;
> - silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> - silabs,pll-master;
> };
Jean-Francois,
thanks for the patch! If we have no use for clkout1 at all on CuBox,
we can also remove the above completely.
For this or an updated patch which removes clkout1 completely:
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> clkout2 {
> reg = <2>;
> + silabs,drive-strength = <8>;
> silabs,multisynth-source = <1>;
> silabs,clock-source = <0>;
> + silabs,pll-master;
> };
> };
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 10:21 [PATCH] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio Jean-Francois Moine
2013-10-04 10:22 ` Sebastian Hesselbarth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).