From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: provide public clk_is_enabled function
Date: Mon, 07 Oct 2013 10:39:21 +0200 [thread overview]
Message-ID: <52527339.9090701@gmail.com> (raw)
In-Reply-To: <CAPtuhTiaTX1VX0OnkJN6AeqtT+FW+uK7022iJ2wOCirQmMXH4Q@mail.gmail.com>
On 10/06/2013 11:04 PM, Mike Turquette wrote:
> On Sun, Oct 6, 2013 at 3:24 PM, Sebastian Hesselbarth
> <sebastian.hesselbarth@gmail.com> wrote:
>> Of course, we can do clk_enable, read, clk_disable as said before - and
>> given the amount of questions and misinterpretation, I think it is the
>> saner way.
>
> Sorry for any misinterpretation on my end. I agree reading the
> register(s) within a clk_enable/clk_disable-protected section is the
> most sane option.
Well, as you are not the only one misinterpreting the purpose, I
guess it is more about the clk_is_enabled() function itself. Uwe was
very right, that it will lead to patches using it in a wrong way.
Using the common enable/disable functions does no harm to our workaround
and we will use it.
Thanks for taking the time to raise those questions and surface those
critical interpretations early!
Sebastian
next prev parent reply other threads:[~2013-10-07 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 10:08 [PATCH] clk: provide public clk_is_enabled function Sebastian Hesselbarth
2013-10-04 13:17 ` Andrew Lunn
2013-10-05 20:24 ` Uwe Kleine-König
2013-10-05 20:42 ` Andrew Lunn
2013-10-06 9:06 ` Gerhard Sittig
2013-10-06 16:30 ` Andrew Lunn
2013-10-06 19:42 ` Sebastian Hesselbarth
2013-10-06 20:02 ` Mike Turquette
2013-10-06 22:24 ` Sebastian Hesselbarth
2013-10-06 21:04 ` Mike Turquette
2013-10-07 8:39 ` Sebastian Hesselbarth [this message]
2013-10-06 21:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52527339.9090701@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).