From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tlb: __flush_tlb_mm need to use int asid var for BE correct operation
Date: Mon, 07 Oct 2013 12:33:03 +0200 [thread overview]
Message-ID: <52528DDF.4080209@codethink.co.uk> (raw)
In-Reply-To: <1381128458-32140-2-git-send-email-victor.kamensky@linaro.org>
On 07/10/13 08:47, Victor Kamensky wrote:
> __flush_tlb_mm function need to use intermediate 'int' type 'asid'
> variable int tlb_op macro call. Direct use of ASID macro produces
> 64 bit unsigned long long type passed to inline assembler statement
> as 'r' operand (32bit), and resulting behavior is not well specified.
> It works in little endian case, but is broken in big endian case. In
> big endian case gcc generate such code that 0 is passed to
> 'mcr 15, 0, r4, cr8, cr3, {2}' operation.
>
> Note other functions like __local_flush_tlb_mm, and local_flush_tlb_mm
> already use intermediate 'asid' variable in similar code.
>
> Signed-off-by: Victor Kamensky<victor.kamensky@linaro.org>
do the __local_flush_tlb_mm() macros need to be changed to always
ensure they take the lowest word of the two?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2013-10-07 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 6:47 [PATCH] ARM: tlb: __flush_tlb_mm need to use int asid var for BE correct operation Victor Kamensky
2013-10-07 6:47 ` Victor Kamensky
2013-10-07 10:32 ` Ben Dooks
2013-10-07 10:33 ` Ben Dooks [this message]
2013-10-07 10:45 ` Russell King - ARM Linux
2013-10-07 10:49 ` Will Deacon
2013-10-07 10:55 ` Ben Dooks
2013-10-07 13:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52528DDF.4080209@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).