From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
Date: Mon, 07 Oct 2013 21:40:16 -0500 [thread overview]
Message-ID: <52537090.9030704@gmail.com> (raw)
In-Reply-To: <20131008013954.7445.27392@quantum>
On 10/7/13 8:39 PM, Mike Turquette wrote:
> Quoting Olof Johansson (2013-10-07 16:43:14)
>> On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
>>> Quoting Dinh Nguyen (2013-10-07 13:37:29)
>>>> Hi Mike,
>>>>
>>>> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
>>>>> Quoting Dinh Nguyen (2013-08-14 07:57:54)
>>>>>> On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
>>>>>>> On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
>>>>>>>> From: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>>
>>>>>>>> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>>>>>>>>
>>>>>>>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>> Cc: Mike Turquette <mturquette@linaro.org>
>>>>>>>> CC: Arnd Bergmann <arnd@arndb.de>
>>>>>>>> CC: Olof Johansson <olof@lixom.net>
>>>>>>>> Cc: Pavel Machek <pavel@denx.de>
>>>>>>>> Cc: linux-arm-kernel at lists.infradead.org
>>>>>>> Hi Dinh,
>>>>>>>
>>>>>>> Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
>>>>>>> on what the impact here is? mmc doesn't come up at all, or something more
>>>>>>> subtle?
>>>>>> Hi Olof,
>>>>>>
>>>>>> No, this is go into 3.12 as I am still working on the bindings for
>>>>>> SD/MMC.
>>>>>>
>>>>>> The oneliner: "The SD/MMC driver was intermittently not coming up
>>>>>> because it was not able to get the correct clock."
>>>>> Olof, did you take this? If not I'll put it into my next batch of fixes
>>>>> for 3.12.
>>>> No, Olof did not get a chance to pick this up for 3.12. I resent the
>>>> patch with the updated commit message for 3.13:
>>>>
>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
>>> Thanks for the link. I've taken that version into clk-fixes for 3.12.
>>
>> Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
>> to remind me if it happens. A week is the normal grace period. :)
No problem Olof! The patches to enable SDMMC is still floating out there
so there wasn't a huge
hurry for 3.12.
Any chance you might take a look? I'll ping Chris Ball again tomorrow.
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks...
> No problem ;-)
>
> Dinh,
>
> I changed your $SUBJECT line to:
>
> "clk: socfpga: Fix incorrect sdmmc clock name"
>
> Just a simple s/arm/clk/
Thanks Mike!
Dinh
>
> Regards,
> Mike
>
>>
>> -Olof
next prev parent reply other threads:[~2013-10-08 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 15:42 [PATCH] arm: socfpga: Fix incorrect sdmmc clock name dinguyen at altera.com
2013-08-14 5:48 ` Olof Johansson
2013-08-14 14:57 ` Dinh Nguyen
2013-10-07 20:12 ` Mike Turquette
2013-10-07 20:37 ` Dinh Nguyen
2013-10-07 23:28 ` Mike Turquette
2013-10-07 23:43 ` Olof Johansson
2013-10-08 1:39 ` Mike Turquette
2013-10-08 2:40 ` Dinh Nguyen [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-17 16:23 dinguyen at altera.com
2013-09-17 21:51 ` Pavel Machek
2013-10-01 19:28 ` Dinh Nguyen
2013-10-07 23:27 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52537090.9030704@gmail.com \
--to=dinh.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).