From mboxrd@z Thu Jan  1 00:00:00 1970
From: swarren@wwwdotorg.org (Stephen Warren)
Date: Thu, 10 Oct 2013 10:07:38 -0600
Subject: [PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c
In-Reply-To: <20131010111328.GS4233@tbergstrom-lnx.Nvidia.com>
References: <1381231068-6053-1-git-send-email-sachin.kamat@linaro.org>
 <1381231068-6053-3-git-send-email-sachin.kamat@linaro.org>
 <52542E34.6020806@wwwdotorg.org>
 <20131010111328.GS4233@tbergstrom-lnx.Nvidia.com>
Message-ID: <5256D0CA.9010906@wwwdotorg.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
>>> Local variables used only in this file are made static.
>>
> 
> Conceptually they are still exported. So I think it's counterintuitive to
> declare them static. Unless you expect namespace problems, I would rather
> leave it as is.

I forget exactly which symbols this patch changed, but presumably
they're only exported via pointers rather than by symbol name, and isn't
that exactly what static is for?