From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc
Date: Mon, 12 Jan 2015 09:21:05 +0100 [thread overview]
Message-ID: <5265608.Ut8IQVYZc5@wuerfel> (raw)
In-Reply-To: <1421047734-30818-2-git-send-email-wangzhou1@hisilicon.com>
On Monday 12 January 2015 15:28:53 Zhou Wang wrote:
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> ---
I haven't looked at earlier versions, but it looks very good to
me overall. Just add a patch description above please.
One tiny detail:
> +static const struct of_device_id nfc_id_table[] = {
> + { .compatible = "hisilicon,504-nfc" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, nfc_id_table);
> +
> +static struct platform_driver hisi_nfc_driver = {
> + .driver = {
> + .name = "hisi_nand",
> + .of_match_table = of_match_ptr(nfc_id_table),
> + .pm = &hisi_nfc_pm_ops,
> + },
> + .probe = hisi_nfc_probe,
> + .remove = hisi_nfc_remove,
> +};
Remove the of_match_ptr() macro here to avoid a warning when
CONFIG_OF is not set.
Arnd
next prev parent reply other threads:[~2015-01-12 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 7:28 [PATCH v6 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Zhou Wang
2015-01-12 7:28 ` [PATCH v6 1/2] mtd: hisilicon: add a new NAND controller driver for " Zhou Wang
2015-01-12 8:21 ` Arnd Bergmann [this message]
2015-01-12 9:18 ` Zhou Wang
2015-01-13 3:58 ` Brian Norris
2015-01-14 12:34 ` Zhou Wang
2015-01-14 19:25 ` Brian Norris
2015-01-15 1:27 ` Zhou Wang
2015-01-13 4:02 ` Brian Norris
2015-01-14 12:45 ` Zhou Wang
2015-01-12 7:28 ` [PATCH v6 2/2] mtd: hisilicon: add device tree binding documentation Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5265608.Ut8IQVYZc5@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox