From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: socfpga: Remove check for "reg" property in socfpga_clk_init
Date: Tue, 22 Oct 2013 05:45:23 -0500 [thread overview]
Message-ID: <52665743.1000309@gmail.com> (raw)
In-Reply-To: <1381797274-4564-1-git-send-email-dinguyen@altera.com>
Hi Mike,
On 10/14/13 7:34 PM, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The function socfpga_clk_init() can support clocks that do not have a divider
> register, but a fixed-divider that can be read from DTS. Therefore, the "reg"
> property is not a failing condition for socfpga_clk_init().
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/clk/socfpga/clk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> index 5bb848c..7f846bf 100644
> --- a/drivers/clk/socfpga/clk.c
> +++ b/drivers/clk/socfpga/clk.c
> @@ -121,9 +121,7 @@ static __init struct clk *socfpga_clk_init(struct device_node *node,
> int rc;
> u32 fixed_div;
>
> - rc = of_property_read_u32(node, "reg", ®);
> - if (WARN_ON(rc))
> - return NULL;
> + of_property_read_u32(node, "reg", ®);
>
> socfpga_clk = kzalloc(sizeof(*socfpga_clk), GFP_KERNEL);
> if (WARN_ON(!socfpga_clk))
Was wondering if you have gotten a chance to review this patch?
Thanks,
Dinh
prev parent reply other threads:[~2013-10-22 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 0:34 [PATCH] clk: socfpga: Remove check for "reg" property in socfpga_clk_init dinguyen at altera.com
2013-10-22 10:45 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52665743.1000309@gmail.com \
--to=dinh.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).