From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F6FBC433ED for ; Mon, 19 Apr 2021 01:05:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 073A261042 for ; Mon, 19 Apr 2021 01:05:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 073A261042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Message-ID:Date:Mime-Version:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=283EJbc+WbKboWPqqPw1TWP+RDVdcd6zPmVwk09xsuQ=; b=ERx n40mxgKit+6pk9wyW515iuXwazvumaJKGiOtp71L6B2JCODnLR0fMcFryMRrC/i+NOTNxCeSni8eF YnJvPHTFbxSbEeE9LxH9bNlWzLfjWtGFxaC7ZNZ0wlhwpJfPxmGNJQma7mbb3yLZawxUuc1GPCfv5 uocNzxiHCCGv0tAFhP5wpc/y0xQwJbVJ+hDDvJcZkUNdoAKO3o00F58Bdzw7rW4NtLp6zr6UB4YO2 dedOUHDuNGU9yQC/YEtsVUPsQzRkQAIsqPCAMbQbZgj/Q08OgwhngDN72PhDSp++wQOj0dbHz1ICq RNM7gRG7HU6Bzk/aejhq9T/fujBCifw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYIJ0-008qfO-FO; Mon, 19 Apr 2021 01:02:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYIIw-008qf4-Q0 for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 01:02:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:Date: Content-Transfer-Encoding:Content-Type:Mime-Version:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=RXam8/yrKFBoz2nKLPMW+gAL4t/Dm8FLDbdkvQGBxIs=; b=NUSeP6B0LA2ecZ9QNkgkKf1a7W Qpmzqp3Yg7oq+NKiBlI5tM0mxqlut/CpLDPe+qo0dbCinXLwpOO6GbFCdEzhKx7cx8C49lt8YN2mP Mfvby6th1+kkNYCxg1bYG6sc9uEJR2Km40j2aS61EhJj8uGThcV9pLC7luZRu6J1MSRworgVTEK2j pyb4Ao38U5QZWZw08KnwvXMbsCR8a/NhyXy02hcoi7oL7HexT296uuyb41ZRMCTwSCeez62X6YGrA DweXe52d6+M0hLC2LWcjthdnO/M5xz5Vf26SjaKyQ+0pbKM9YIFKZyz5k5zPXWByEOOXNQmMSTXuE 44IFTcjg==; Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYIIq-00ApvG-CV for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 01:02:20 +0000 Received: by mail-qk1-x731.google.com with SMTP id v7so6304985qkj.13 for ; Sun, 18 Apr 2021 18:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:mime-version:content-transfer-encoding :date:message-id; bh=RXam8/yrKFBoz2nKLPMW+gAL4t/Dm8FLDbdkvQGBxIs=; b=H6S169QP79gGhsQKKA2kKXR+4q+a+T0r3ZkwWZ/s+14xnmPs5QDOFVz4mD+J+qqpyf /Bgugt+pTV0U1sQghwysF/aGYIzHJf/47HLCo/H5j52pbR+qPQP32lEkc6lblm/PRfkY TrlNUyyzRwv3tjOW6CVfsBqRUWD4PpYySlLnpAASTqhBjiVGWDvw0yuPTRJwnjK86J9w Sxp4D0M8JJQi901u3BMMhyux/Fb+z7ShsIstoFg908XPswgo45+y3tRalrqGznLSaEAd gCwOK7GPWZgsMbpu6KLZojWlysgEpkO+xe/lhkLauO4ZlQ8w6akiF1DBAHPakaaI25RC k/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:mime-version :content-transfer-encoding:date:message-id; bh=RXam8/yrKFBoz2nKLPMW+gAL4t/Dm8FLDbdkvQGBxIs=; b=Y/EnrH3cXZoD1kC9mSKkzAl/RPP52nnDDxdmz+RVcuWfi9EZLELycYpCHiUgh4cNnP FYEEKHEY8ko0tGiJ9DLkqL2NLabzlWfkaai75mVNi73/MnllBI9ihqQjvqMmsQOxTevQ 9DE2hhs8WNYIlKq8p93NiGdpsCuu5c/Euuaawy2rWTFAeeF4jDah5/vjuMYKmAgdNw9e svkI3xrF70RsXzUjlAU9kKIDJ7Udb7z9kEXvMoK5dwVoZfpcjKiS7b+xHhnsLOlkJiea k6vrqihSgP26SROOjTE5sgc5ElKG29Rqr3xhXqPBBJ5kchQYgh358vyqySuqYGnqAErw UyWg== X-Gm-Message-State: AOAM530AHF5LXCKt/jP3oMSBTplBeNc6GCQFUwZHGEg4xN7M7qOF8EKF h1lk5nWShuDxnb9orhdCx0fpMg== X-Google-Smtp-Source: ABdhPJy0Kau8aXbq90XTNnBOjhUdqhQzEs89RasWQd28uDmQRXyvdq30ubbRcFkERw/LLHo9M3Q+pg== X-Received: by 2002:a37:e30c:: with SMTP id y12mr9437334qki.244.1618794134634; Sun, 18 Apr 2021 18:02:14 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id f8sm676599qkh.83.2021.04.18.18.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Apr 2021 18:02:14 -0700 (PDT) From: "Valdis =?utf-8?Q?Kl=c4=93tnieks?=" X-Google-Original-From: "Valdis =?utf-8?Q?Kl=c4=93tnieks?=" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Felix Fietkau , Pablo Neira Ayuso , "David S. Miller" Cc: Christoph Hellwig , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: drivers/net/ethernet/mediatek/mtk_ppe_offload.c - suspicious code? Mime-Version: 1.0 Date: Sun, 18 Apr 2021 21:02:12 -0400 Message-ID: <526789.1618794132@turing-police> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210418_180216_609453_D21BF12A X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3996888719883376195==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3996888719883376195== Content-Type: multipart/signed; boundary="==_Exmh_1618794132_13593P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1618794132_13593P Content-Type: text/plain; charset=us-ascii While doing some code auditing for -Woverride_init, I spotted some questionable code commit 502e84e2382d92654a2ecbc52cdbdb5a11cdcec7 Author: Felix Fietkau Date: Wed Mar 24 02:30:54 2021 +0100 net: ethernet: mtk_eth_soc: add flow offloading support In drivers/net/ethernet/mediatek/mtk_ppe_offload.c: +static const struct rhashtable_params mtk_flow_ht_params = { + .head_offset = offsetof(struct mtk_flow_entry, node), + .head_offset = offsetof(struct mtk_flow_entry, cookie), + .key_len = sizeof(unsigned long), + .automatic_shrinking = true, +}; What's intended for head_offset here? Christoph: This was the only actual questionable code caught by override-init across allmodconfig builds of arm, arm64, and x86_64. The other 218 warnings not already silenced by Makefile twiddling of CFLAGS are all legitimate. I admit not being sure what that means for its use in W=1 builds in general. --==_Exmh_1618794132_13593P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBYHzWlAdmEQWDXROgAQKBMRAArsoGj4sOoT0DAvTbdQb1ePhTUDMRptuS rjlchzSFgPmnVRcZA7uHfMclr06Sv4Z7x3YUi1B9EoVpCJ7636ZVvYH4C1moc6bc u6bwTdsS1BfpbDy7UJB3J+81f6TvsajnNMaTVvJKyX83zoCw64gkozaoaKRTlLfo bC2WoqTVqSyfSKWx4k3dC22A6U5FnFhmxulr3FAhbd6gg50LqWn4zA8lpILIpAMW XIRZMHPDqCQ4HLck6lRj4Toj1KUYKA6c9nWr31zHCd+yBwDGB479jNc578gSHYL9 OJ4z7Kb/S/fIMilkNrjo36qqmiW5XS/vW55GDSpq0yhLzlSdwrQbhd33x/+y9w11 GgLRSSSL5W7JDpGaUcOJkV9j5vAVG6AB+3j60RdzR9rDF59L/jnCp++lilrcsW3a A9iyYczjbT3s0DwZmwC1NTk3L/Sq0T27wAKgojgacJ1eNGVRZy/njR2tFfwTqord j/5MDKBdB7oNzuvmVuJG4+m//ModL/oPC9vx8nZJgZiS4JpfIwHXDlZdPwZlR8lC SAl5LHU+5GD4EN4ZjoCn2Ocl0veShZoKYr9TQXXWPg3W5uKCoFioWqO+wIeL0mop 5nu6OAf1KvGq3KmP/dqBA9GElv3GaUkf75kRoK8gED6rLjP+kqcThndQzGFQOo7E GK82Pd1kWTM= =YBHY -----END PGP SIGNATURE----- --==_Exmh_1618794132_13593P-- --===============3996888719883376195== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3996888719883376195==--