[PATCH] ARM: dts: Add initial support for cm-fx6

[PATCH] ARM: dts: Add initial support for cm-fx6

[Valentin Raevsky]

Add initial support for cm-fx6 module.

cm-fx6 is a module based on mx6q SoC with the following features:
- Up to 4GB of DDR3
- 1 LCD/DVI output port
- 1 HDMI output port
- 2 LVDS LCD ports
- Gigabit Ethernet
- Analog Audio
- CAN
- SATA
- NAND
- PCIE

This patch allows to boot up the module, configures the serial console,
the Ethernet adapter and the hearbeat led.

Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
---
 arch/arm/boot/dts/cm-fx6.dts |   51 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 arch/arm/boot/dts/cm-fx6.dts

diff --git a/arch/arm/boot/dts/cm-fx6.dts b/arch/arm/boot/dts/cm-fx6.dts
new file mode 100644
index 0000000..1080215
--- /dev/null
+++ b/arch/arm/boot/dts/cm-fx6.dts
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2013 CompuLab Ltd.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx6q.dtsi"
+
+/ {
+	model = "CompuLab CM-FX6";
+	compatible = "compulab,cm-fx6", "fsl,imx6q";
+
+	memory {
+		reg = <0x10000000 0x80000000>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		debug-led {
+			label = "Heartbeat";
+			gpios = <&gpio2 31 0>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+};
+
+&gpmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_gpmi_nand_1>;
+	status = "okay";
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_enet_1>;
+	phy-mode = "rgmii";
+	status = "okay";
+};
+
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4_1>;
+	status = "okay";
+};
-- 
1.7.9.5

[PATCH] ARM: dts: Add initial support for cm-fx6

[Steev Klimaszewski]

On Tue, Oct 15, 2013 at 9:49 AM, Valentin Raevsky
<valentin@compulab.co.il> wrote:
> Add initial support for cm-fx6 module.
>
> cm-fx6 is a module based on mx6q SoC with the following features:
> - Up to 4GB of DDR3
> - 1 LCD/DVI output port
> - 1 HDMI output port
> - 2 LVDS LCD ports
> - Gigabit Ethernet
> - Analog Audio
> - CAN
> - SATA
> - NAND
> - PCIE
>
> This patch allows to boot up the module, configures the serial console,
> the Ethernet adapter and the hearbeat led.
>
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>  arch/arm/boot/dts/cm-fx6.dts |   51 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 arch/arm/boot/dts/cm-fx6.dts
>
> diff --git a/arch/arm/boot/dts/cm-fx6.dts b/arch/arm/boot/dts/cm-fx6.dts
> new file mode 100644
> index 0000000..1080215
> --- /dev/null
> +++ b/arch/arm/boot/dts/cm-fx6.dts
> @@ -0,0 +1,51 @@
> +/*
> + * Copyright 2013 CompuLab Ltd.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +#include "imx6q.dtsi"
> +
> +/ {
> +       model = "CompuLab CM-FX6";
> +       compatible = "compulab,cm-fx6", "fsl,imx6q";
> +
> +       memory {
> +               reg = <0x10000000 0x80000000>;
> +       };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               debug-led {
> +                       label = "Heartbeat";
> +                       gpios = <&gpio2 31 0>;
> +                       linux,default-trigger = "heartbeat";
> +               };
> +       };
> +};
> +
> +&gpmi {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_gpmi_nand_1>;
> +       status = "okay";
> +};
> +
> +&fec {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_enet_1>;
> +       phy-mode = "rgmii";
> +       status = "okay";
> +};
> +
> +&uart4 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_uart4_1>;
> +       status = "okay";
> +};
> --
> 1.7.9.5
>

Hi Valentin,

Completely skipped over this, as I wasn't sure what the cm-fx6 was.
Could we maybe mention that this is commonly referred to as the
Utilite?

-- 
This e-mail and any attachments are for the sole use of the intended 
recipients(s) and may be confidential. Use of any Pwnie Express product 
signifies your agreement to the Rapid Focus Security EULA<http://pwnieexpress.com/pdfs/RFSEULA.pdf>and is subject to export controls under the U.S. Commerce Department's 
Export Administration Regulations ("EAR").

[PATCH] ARM: dts: Add initial support for cm-fx6

[Shawn Guo]

On Tue, Oct 15, 2013 at 05:49:24PM +0300, Valentin Raevsky wrote:
> Add initial support for cm-fx6 module.
> 
> cm-fx6 is a module based on mx6q SoC with the following features:
> - Up to 4GB of DDR3
> - 1 LCD/DVI output port
> - 1 HDMI output port
> - 2 LVDS LCD ports
> - Gigabit Ethernet
> - Analog Audio
> - CAN
> - SATA
> - NAND
> - PCIE
> 
> This patch allows to boot up the module, configures the serial console,
> the Ethernet adapter and the hearbeat led.
> 
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>  arch/arm/boot/dts/cm-fx6.dts |   51 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 arch/arm/boot/dts/cm-fx6.dts

Please name the file with 'imx6q-' prefix, and add dtb target into
arch/arm/boot/dts/Makefile.

> 
> diff --git a/arch/arm/boot/dts/cm-fx6.dts b/arch/arm/boot/dts/cm-fx6.dts
> new file mode 100644
> index 0000000..1080215
> --- /dev/null
> +++ b/arch/arm/boot/dts/cm-fx6.dts
> @@ -0,0 +1,51 @@
> +/*
> + * Copyright 2013 CompuLab Ltd.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +#include "imx6q.dtsi"
> +
> +/ {
> +	model = "CompuLab CM-FX6";
> +	compatible = "compulab,cm-fx6", "fsl,imx6q";
> +
> +	memory {
> +		reg = <0x10000000 0x80000000>;
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		debug-led {
> +			label = "Heartbeat";
> +			gpios = <&gpio2 31 0>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +};
> +
> +&gpmi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_gpmi_nand_1>;
> +	status = "okay";
> +};
> +
> +&fec {

Please sort the nodes alphabetically in label names.

Shawn

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet_1>;
> +	phy-mode = "rgmii";
> +	status = "okay";
> +};
> +
> +&uart4 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart4_1>;
> +	status = "okay";
> +};
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] ARM: dts: Add initial support for cm-fx6

[Valentin Raevsky]

On 10/17/2013 04:45 AM, Steev Klimaszewski wrote:
> On Tue, Oct 15, 2013 at 9:49 AM, Valentin Raevsky
> <valentin@compulab.co.il> wrote:
>> Add initial support for cm-fx6 module.
>>
>> cm-fx6 is a module based on mx6q SoC with the following features:
>> - Up to 4GB of DDR3
>> - 1 LCD/DVI output port
>> - 1 HDMI output port
>> - 2 LVDS LCD ports
>> - Gigabit Ethernet
>> - Analog Audio
>> - CAN
>> - SATA
>> - NAND
>> - PCIE
>>
>> This patch allows to boot up the module, configures the serial console,
>> the Ethernet adapter and the hearbeat led.
>>
>> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>>   arch/arm/boot/dts/cm-fx6.dts |   51 ++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/cm-fx6.dts
>>
>> diff --git a/arch/arm/boot/dts/cm-fx6.dts b/arch/arm/boot/dts/cm-fx6.dts
>> new file mode 100644
>> index 0000000..1080215
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/cm-fx6.dts
>> @@ -0,0 +1,51 @@
>> +/*
>> + * Copyright 2013 CompuLab Ltd.
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +/dts-v1/;
>> +#include "imx6q.dtsi"
>> +
>> +/ {
>> +       model = "CompuLab CM-FX6";
>> +       compatible = "compulab,cm-fx6", "fsl,imx6q";
>> +
>> +       memory {
>> +               reg = <0x10000000 0x80000000>;
>> +       };
>> +
>> +       leds {
>> +               compatible = "gpio-leds";
>> +
>> +               debug-led {
>> +                       label = "Heartbeat";
>> +                       gpios = <&gpio2 31 0>;
>> +                       linux,default-trigger = "heartbeat";
>> +               };
>> +       };
>> +};
>> +
>> +&gpmi {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_gpmi_nand_1>;
>> +       status = "okay";
>> +};
>> +
>> +&fec {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_enet_1>;
>> +       phy-mode = "rgmii";
>> +       status = "okay";
>> +};
>> +
>> +&uart4 {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_uart4_1>;
>> +       status = "okay";
>> +};
>> --
>> 1.7.9.5
>>
>
> Hi Valentin,
>
> Completely skipped over this, as I wasn't sure what the cm-fx6 was.
> Could we maybe mention that this is commonly referred to as the
> Utilite?
>

Utilite actually consists of two boards:
cm-fx6 -- system on module, sb-fx6m -- base board (extension board).
But you are right, I should have mentioned it.
I will do it in v2.

Regards,
Valentin.

[PATCH] ARM: dts: Add initial support for cm-fx6

[Valentin Raevsky]

On 10/21/2013 08:06 AM, Shawn Guo wrote:
> On Tue, Oct 15, 2013 at 05:49:24PM +0300, Valentin Raevsky wrote:
>> Add initial support for cm-fx6 module.
>>
>> cm-fx6 is a module based on mx6q SoC with the following features:
>> - Up to 4GB of DDR3
>> - 1 LCD/DVI output port
>> - 1 HDMI output port
>> - 2 LVDS LCD ports
>> - Gigabit Ethernet
>> - Analog Audio
>> - CAN
>> - SATA
>> - NAND
>> - PCIE
>>
>> This patch allows to boot up the module, configures the serial console,
>> the Ethernet adapter and the hearbeat led.
>>
>> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>>   arch/arm/boot/dts/cm-fx6.dts |   51 ++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/cm-fx6.dts
>
> Please name the file with 'imx6q-' prefix, and add dtb target into
> arch/arm/boot/dts/Makefile.

thatnks, got it. will be in v2.

>
>>
>> diff --git a/arch/arm/boot/dts/cm-fx6.dts b/arch/arm/boot/dts/cm-fx6.dts
>> new file mode 100644
>> index 0000000..1080215
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/cm-fx6.dts
>> @@ -0,0 +1,51 @@
>> +/*
>> + * Copyright 2013 CompuLab Ltd.
>> + *
>> + * The code contained herein is licensed under the GNU General Public
>> + * License. You may obtain a copy of the GNU General Public License
>> + * Version 2 or later at the following locations:
>> + *
>> + * http://www.opensource.org/licenses/gpl-license.html
>> + * http://www.gnu.org/copyleft/gpl.html
>> + */
>> +
>> +/dts-v1/;
>> +#include "imx6q.dtsi"
>> +
>> +/ {
>> +	model = "CompuLab CM-FX6";
>> +	compatible = "compulab,cm-fx6", "fsl,imx6q";
>> +
>> +	memory {
>> +		reg = <0x10000000 0x80000000>;
>> +	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		debug-led {
>> +			label = "Heartbeat";
>> +			gpios = <&gpio2 31 0>;
>> +			linux,default-trigger = "heartbeat";
>> +		};
>> +	};
>> +};
>> +
>> +&gpmi {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_gpmi_nand_1>;
>> +	status = "okay";
>> +};
>> +
>> +&fec {
>
> Please sort the nodes alphabetically in label names.

got it. will be in v2.

>
> Shawn
>
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_enet_1>;
>> +	phy-mode = "rgmii";
>> +	status = "okay";
>> +};
>> +
>> +&uart4 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart4_1>;
>> +	status = "okay";
>> +};
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[PATCH] ARM: dts: Add initial support for cm-fx6.

[Valentin Raevsky]

Add initial support for cm-fx6 module.

cm-fx6 is a module based on mx6q SoC with the following features:
- Up to 4GB of DDR3
- 1 LCD/DVI output port
- 1 HDMI output port
- 2 LVDS LCD ports
- Gigabit Ethernet
- Analog Audio
- CAN
- SATA
- NAND
- PCIE

This patch allows to boot up the module, configures the serial console,
the Ethernet adapter and the heartbeat led.

cm-fx6 is embedded inside the Utilite computer.

Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---

Shawn, can this still be applied for 3.13 ?

 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/imx6q-cm-fx6.dts |   53 ++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-cm-fx6.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 641b3c9..87ca7ca 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx6q-sabrelite.dtb \
 	imx6q-sabresd.dtb \
 	imx6q-sbc6x.dtb \
+	imx6q-cm-fx6.dtb \
 	imx6sl-evk.dtb \
 	vf610-twr.dtb
 dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
diff --git a/arch/arm/boot/dts/imx6q-cm-fx6.dts b/arch/arm/boot/dts/imx6q-cm-fx6.dts
new file mode 100644
index 0000000..2419751
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-cm-fx6.dts
@@ -0,0 +1,53 @@
+/*
+ * Copyright 2013 CompuLab Ltd.
+ *
+ * Author: Valentin Raevsky <valentin@compulab.co.il>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx6q.dtsi"
+
+/ {
+	model = "CompuLab CM-FX6";
+	compatible = "compulab,cm-fx6", "fsl,imx6q";
+
+	memory {
+		reg = <0x10000000 0x80000000>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		heartbeat-led {
+			label = "Heartbeat";
+			gpios = <&gpio2 31 0>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_enet_1>;
+	phy-mode = "rgmii";
+	status = "okay";
+};
+
+&gpmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_gpmi_nand_1>;
+	status = "okay";
+};
+
+&uart4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart4_1>;
+	status = "okay";
+};
-- 
1.7.9.5

[PATCH] ARM: dts: Add initial support for cm-fx6.

[Shawn Guo]

On Tue, Oct 29, 2013 at 02:11:43PM +0200, Valentin Raevsky wrote:
> Add initial support for cm-fx6 module.
> 
> cm-fx6 is a module based on mx6q SoC with the following features:
> - Up to 4GB of DDR3
> - 1 LCD/DVI output port
> - 1 HDMI output port
> - 2 LVDS LCD ports
> - Gigabit Ethernet
> - Analog Audio
> - CAN
> - SATA
> - NAND
> - PCIE
> 
> This patch allows to boot up the module, configures the serial console,
> the Ethernet adapter and the heartbeat led.
> 
> cm-fx6 is embedded inside the Utilite computer.
> 
> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> 
> Shawn, can this still be applied for 3.13 ?

Sorry, it's late for 3.13.  Applied for 3.14 with a small fix-up below.

> 
>  arch/arm/boot/dts/Makefile         |    1 +
>  arch/arm/boot/dts/imx6q-cm-fx6.dts |   53 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-cm-fx6.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 641b3c9..87ca7ca 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>  	imx6q-sabrelite.dtb \
>  	imx6q-sabresd.dtb \
>  	imx6q-sbc6x.dtb \
> +	imx6q-cm-fx6.dtb \

If you look at the list, you can find that they are sorted
alphabetically.  I just moved it around to maintain the order.

Shawn

>  	imx6sl-evk.dtb \
>  	vf610-twr.dtb
>  dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \

[PATCH] ARM: dts: Add initial support for cm-fx6.

[Igor Grinberg]

On 10/31/13 07:56, Shawn Guo wrote:
> On Tue, Oct 29, 2013 at 02:11:43PM +0200, Valentin Raevsky wrote:
>> Add initial support for cm-fx6 module.
>>
>> cm-fx6 is a module based on mx6q SoC with the following features:
>> - Up to 4GB of DDR3
>> - 1 LCD/DVI output port
>> - 1 HDMI output port
>> - 2 LVDS LCD ports
>> - Gigabit Ethernet
>> - Analog Audio
>> - CAN
>> - SATA
>> - NAND
>> - PCIE
>>
>> This patch allows to boot up the module, configures the serial console,
>> the Ethernet adapter and the heartbeat led.
>>
>> cm-fx6 is embedded inside the Utilite computer.
>>
>> Signed-off-by: Valentin Raevsky <valentin@compulab.co.il>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>>
>> Shawn, can this still be applied for 3.13 ?
> 
> Sorry, it's late for 3.13.  Applied for 3.14 with a small fix-up below.

Thanks!

> 
>>
>>  arch/arm/boot/dts/Makefile         |    1 +
>>  arch/arm/boot/dts/imx6q-cm-fx6.dts |   53 ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 54 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-cm-fx6.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 641b3c9..87ca7ca 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -131,6 +131,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>>  	imx6q-sabrelite.dtb \
>>  	imx6q-sabresd.dtb \
>>  	imx6q-sbc6x.dtb \
>> +	imx6q-cm-fx6.dtb \
> 
> If you look at the list, you can find that they are sorted
> alphabetically.  I just moved it around to maintain the order.

Sorry for that. Thanks for fixing this up!

-- 
Regards,
Igor.