From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] arm64: use for_each_node_by_type() macro
Date: Wed, 30 Oct 2013 00:35:26 -0500 [thread overview]
Message-ID: <52709A9E.8060800@gmail.com> (raw)
In-Reply-To: <CAPgLHd_aQROa0-vycghYz9A9Jx4MbC131C819xPHZg_hrTQC7w@mail.gmail.com>
On 10/30/2013 12:25 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use for_each_node_by_type() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> arch/arm64/kernel/cpu_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
> index aa0c9e7..37a4977 100644
> --- a/arch/arm64/kernel/cpu_ops.c
> +++ b/arch/arm64/kernel/cpu_ops.c
> @@ -78,10 +78,10 @@ int __init cpu_read_ops(struct device_node *dn, int cpu)
>
> void __init cpu_read_bootcpu_ops(void)
> {
> - struct device_node *dn = NULL;
> + struct device_node *dn;
> u64 mpidr = cpu_logical_map(0);
>
> - while ((dn = of_find_node_by_type(dn, "cpu"))) {
> + for_each_node_by_type(dn, "cpu") {
^
Extra space here.
> u64 hwid;
> const __be32 *prop;
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2013-10-30 5:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 5:25 [PATCH -next] arm64: use for_each_node_by_type() macro Wei Yongjun
2013-10-30 5:35 ` Rob Herring [this message]
2013-10-30 5:54 ` [PATCH -next v2] " Wei Yongjun
2013-10-30 10:54 ` Catalin Marinas
2013-10-30 11:49 ` Sudeep KarkadaNagesha
2013-10-30 12:16 ` Catalin Marinas
2013-10-30 14:22 ` Sudeep KarkadaNagesha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52709A9E.8060800@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).