From: jiada_wang@mentor.com (jiada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: replace imx6q_restart() with mxc_restart()
Date: Wed, 30 Oct 2013 22:31:54 -0700 [thread overview]
Message-ID: <5271EB4A.2080707@mentor.com> (raw)
In-Reply-To: <20131030175426.GK16735@n2100.arm.linux.org.uk>
Hi
On 10/30/2013 10:54 AM, Russell King - ARM Linux wrote:
> On Tue, Oct 29, 2013 at 08:13:02PM -0700, jiada wrote:
>> Hi
>>
>> On 10/28/2013 12:45 AM, Shawn Guo wrote:
>>> 1. Apply the following change
>>>
>>> https://git.linaro.org/gitweb?p=people/shawnguo/linux-2.6.git;a=commitdiff;h=6050d181a4fd4abb745506a6e565d55f1f9df964
>>>
>>> 2. Remove imx_src_prepare_restart() from imx6q_restart().
>>>
>>> I will send a patch against the latest kernel.
>>>
>> Thanks Shawn, I have verified with these two changes,
>> system reboot by "echo b > /proc/sysrq-trigger" works
>> for me.
>
> The test you really want to do is a reboot via serial console: <break> b.
> That's definitely the one which will get you if your restart handler has
> anything in it which sleeps. This will definitely call the restart
> handler from IRQ context.
>
Yes, I tested both "echo b > /proc/sysrq-trigger" and console: <break> b
reboot, but with out this fix patch, previously I saw problem when
reboot by "echo b > /proc/sysrq-trigger".
with this fix patch, both way work fine.
Thanks,
Jiada
next prev parent reply other threads:[~2013-10-31 5:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 9:06 [PATCH] ARM: imx: replace imx6q_restart() with mxc_restart() Shawn Guo
2013-10-08 15:32 ` Nathan Lynch
2013-10-08 15:49 ` Shawn Guo
[not found] ` <857E9EDCA6C0904DB3357321AA9123EB62506837@NA-MBX-01.mgc.mentorg.com>
2013-10-21 3:32 ` jiada
2013-10-21 4:59 ` Shawn Guo
[not found] ` <857E9EDCA6C0904DB3357321AA9123EB62506BEA@NA-MBX-01.mgc.mentorg.com>
2013-10-21 6:13 ` jiada
2013-10-21 7:04 ` Shawn Guo
2013-10-28 2:41 ` jiada
2013-10-28 2:52 ` Shawn Guo
2013-10-28 7:45 ` Shawn Guo
2013-10-30 3:13 ` jiada
2013-10-30 17:54 ` Russell King - ARM Linux
2013-10-31 5:23 ` Shawn Guo
2013-10-31 5:31 ` jiada [this message]
2013-10-28 5:17 ` Olof Johansson
2013-10-28 8:14 ` Shawn Guo
2013-10-28 17:46 ` Olof Johansson
2013-10-29 2:06 ` Shawn Guo
2013-10-29 8:53 ` Lothar Waßmann
2013-10-29 11:37 ` Russell King - ARM Linux
2013-10-29 13:37 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271EB4A.2080707@mentor.com \
--to=jiada_wang@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).