From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Sat, 02 Nov 2013 03:30:25 +0300 Subject: [PATCH] RM: shmobile: lager: phy fixup needs CONFIG_PHYLIB In-Reply-To: <20131101004359.GK6818@verge.net.au> References: <1383201098-4258-1-git-send-email-horms+renesas@verge.net.au> <5272CC16.3020700@cogentembedded.com> <20131101004359.GK6818@verge.net.au> Message-ID: <527447A1.2000607@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/01/2013 03:43 AM, Simon Horman wrote: >>> Do not build the phy fixup unless CONFIG_PHYLIB is enabled. >>> Other than not being useful it is also not possible to compile >> s/compile/link/. >>> the code under this condition as phy_register_fixup_for_id() >>> is not defined. >> Not only this function is absent... >>> This problem was introduced by 48c8b96f21817aad >>> ("ARM: shmobile: Lager: add Micrel KSZ8041 PHY fixup") >>> Cc: Sergei Shtylyov >>> Signed-off-by: Simon Horman >>> --- >>> arch/arm/mach-shmobile/board-lager.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c >>> index 78a31b6..d1a8ddd 100644 >>> --- a/arch/arm/mach-shmobile/board-lager.c >>> +++ b/arch/arm/mach-shmobile/board-lager.c >>> @@ -245,7 +245,9 @@ static void __init lager_init(void) >>> { >>> lager_add_standard_devices(); >>> >>> - phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup); >>> + if (IS_ENABLED(CONFIG_PHYLIB)) >>> + phy_register_fixup_for_id("r8a7790-ether-ff:01", >>> + lager_ksz8041_fixup); >> Perhaps you would consider enclosing the fixup function itself >> into #ifdef as it causes link errors as well? Doesn't seem >> necessary as gcc probably drops it anyway but for completeness' >> sake... > My understanding of the motivation for IS_ENABLED() is to > take advantage of gcc optimising away unused code and making such > problems disappear. > With this patch in place do you still see any warnings? No (but those were errors :-). I'd like the changelog to be adjusted at least... WBR, Sergei