* [patch] [media] exynos4-is: cleanup a define
@ 2013-11-08 9:52 Dan Carpenter
2013-11-08 22:17 ` Sylwester Nawrocki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-08 9:52 UTC (permalink / raw)
To: linux-arm-kernel
This define is only used in s5pcsis_irq_handler():
if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) {
The problem is that "status" is a 32 bit and (0xff << 28) is larger than
32 bits and that sets off a static checker warning. I consulted with
Sylwester Nawrocki and the define should actually be (0xf << 28).
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c
index 9fc2af6..31dfc50 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform/exynos4-is/mipi-csis.c
@@ -91,7 +91,7 @@ MODULE_PARM_DESC(debug, "Debug level (0-2)");
#define S5PCSIS_INTSRC_ODD_BEFORE (1 << 29)
#define S5PCSIS_INTSRC_ODD_AFTER (1 << 28)
#define S5PCSIS_INTSRC_ODD (0x3 << 28)
-#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff << 28)
+#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xf << 28)
#define S5PCSIS_INTSRC_FRAME_START (1 << 27)
#define S5PCSIS_INTSRC_FRAME_END (1 << 26)
#define S5PCSIS_INTSRC_ERR_SOT_HS (0xf << 12)
^ permalink raw reply related [flat|nested] 2+ messages in thread* [patch] [media] exynos4-is: cleanup a define
2013-11-08 9:52 [patch] [media] exynos4-is: cleanup a define Dan Carpenter
@ 2013-11-08 22:17 ` Sylwester Nawrocki
0 siblings, 0 replies; 2+ messages in thread
From: Sylwester Nawrocki @ 2013-11-08 22:17 UTC (permalink / raw)
To: linux-arm-kernel
(dropping some unrelated e-mail addresses from Cc)
On 11/08/2013 10:52 AM, Dan Carpenter wrote:
> This define is only used in s5pcsis_irq_handler():
>
> if ((status& S5PCSIS_INTSRC_NON_IMAGE_DATA)&& pktbuf->data) {
>
> The problem is that "status" is a 32 bit and (0xff<< 28) is larger than
> 32 bits and that sets off a static checker warning. I consulted with
> Sylwester Nawrocki and the define should actually be (0xf<< 28).
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Thanks for the fix, patch added to my tree for v3.14.
> diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c
> index 9fc2af6..31dfc50 100644
> --- a/drivers/media/platform/exynos4-is/mipi-csis.c
> +++ b/drivers/media/platform/exynos4-is/mipi-csis.c
> @@ -91,7 +91,7 @@ MODULE_PARM_DESC(debug, "Debug level (0-2)");
> #define S5PCSIS_INTSRC_ODD_BEFORE (1<< 29)
> #define S5PCSIS_INTSRC_ODD_AFTER (1<< 28)
> #define S5PCSIS_INTSRC_ODD (0x3<< 28)
> -#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff<< 28)
> +#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xf<< 28)
> #define S5PCSIS_INTSRC_FRAME_START (1<< 27)
> #define S5PCSIS_INTSRC_FRAME_END (1<< 26)
> #define S5PCSIS_INTSRC_ERR_SOT_HS (0xf<< 12)
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-08 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 9:52 [patch] [media] exynos4-is: cleanup a define Dan Carpenter
2013-11-08 22:17 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).