From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: sirf: enable generic dt binding for dma channels
Date: Mon, 11 Nov 2013 15:29:06 +0100 [thread overview]
Message-ID: <5280E9B2.9090309@metafoo.de> (raw)
In-Reply-To: <1384161191-24140-1-git-send-email-Baohua.Song@csr.com>
On 11/11/2013 10:13 AM, Barry Song wrote:
[...]
> +static struct dma_chan *of_dma_sirfsoc_xlate(struct of_phandle_args *dma_spec,
> + struct of_dma *ofdma)
> +{
> + struct sirfsoc_dma *sdma = ofdma->of_dma_data;
> + struct sirfsoc_dma_filter_args fargs;
> +
> + if (!sdma)
> + return NULL;
> +
> + if (dma_spec->args_count != 1)
> + return NULL;
> +
> + fargs.sdma = sdma;
> + fargs.chan_id = dma_spec->args[0];
> +
> + return dma_request_channel(sdma->cap, sirfsoc_dma_dt_filter, &fargs);
> +}
There is now the dma_get_slave_channel() function which makes it a bit
cleaner to implement this. I think you can use the k3dma driver as an example.
- Lars
prev parent reply other threads:[~2013-11-11 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 9:13 [PATCH] dmaengine: sirf: enable generic dt binding for dma channels Barry Song
2013-11-11 14:29 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280E9B2.9090309@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).