From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Fri, 15 Nov 2013 11:58:50 +0000 Subject: [PATCH 5/6] ARM: kvm: Use phys_addr_t instead of unsigned long in mm code In-Reply-To: <1384457866-16135-6-git-send-email-santosh.shilimkar@ti.com> References: <1384457866-16135-1-git-send-email-santosh.shilimkar@ti.com> <1384457866-16135-6-git-send-email-santosh.shilimkar@ti.com> Message-ID: <52860C7A.1020109@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14/11/13 19:37, Santosh Shilimkar wrote: > The unsigned long datatype is not sufficient for mapping physical addresses > greater than 4GB. > > So fix the KVM mm code accordingly. Special thanks to Christopher for debug > help to figure out the bug. > > Cc: Christoffer Dall > Cc: Marc Zyngier > > Signed-off-by: Santosh Shilimkar Nice catch. Acked-by: Marc Zyngier M. > --- > arch/arm/kvm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 3bd652f..657f15e 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -318,7 +318,7 @@ out: > */ > int create_hyp_mappings(void *from, void *to) > { > - unsigned long phys_addr = virt_to_phys(from); > + phys_addr_t phys_addr = virt_to_phys(from); > unsigned long start = KERN_TO_HYP((unsigned long)from); > unsigned long end = KERN_TO_HYP((unsigned long)to); > > -- Jazz is not dead. It just smells funny...