From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] CMA: Fix the phys_addr_t print types
Date: Sat, 23 Nov 2013 22:45:37 -0500 [thread overview]
Message-ID: <52917661.6050005@ti.com> (raw)
In-Reply-To: <20131124034426.GB3873@kroah.com>
On Saturday 23 November 2013 10:44 PM, Greg Kroah-Hartman wrote:
> On Sat, Nov 23, 2013 at 10:37:01PM -0500, Santosh Shilimkar wrote:
>> @@ -250,8 +249,8 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, phys_addr_t base,
>> *res_cma = cma;
>> cma_area_count++;
>>
>> - pr_info("CMA: reserved %ld MiB at %08lx\n", (unsigned long)size / SZ_1M,
>> - (unsigned long)base);
>> + pr_info("CMA: reserved %ld MiB at %pa\n", (unsigned long)size / SZ_1M,
>> + &base);
>
> Why is this pr_info() at all? That's just noise, please move it to
> pr_debug().
>
Marek can comment better but I think its useful print to know CMA
reserved memory size.
regards,
Santosh
next prev parent reply other threads:[~2013-11-24 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 3:37 [PATCH] CMA: Fix the phys_addr_t print types Santosh Shilimkar
2013-11-24 3:43 ` Greg Kroah-Hartman
2013-11-24 3:44 ` Santosh Shilimkar
2013-11-24 3:44 ` Greg Kroah-Hartman
2013-11-24 3:45 ` Santosh Shilimkar [this message]
2013-11-24 4:10 ` Greg Kroah-Hartman
2013-11-24 4:28 ` Santosh Shilimkar
2013-11-25 10:46 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52917661.6050005@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).