* [GIT PULL][for 3.14] pull request to enable Hisilicon SoC from pxa git tree
@ 2013-11-25 3:07 Haojian Zhuang
2013-11-25 4:05 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Haojian Zhuang @ 2013-11-25 3:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof & Kevin,
Here's the pull request from pxa git tree to enable Hisilicon Hi3620
SoC. Please help to merge.
Best Regards
Haojian
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
are available in the git repository at:
http://git.kernel.org/pub/scm/linux/kernel/git/hzhuang1/linux.git
tags/hisilicon-init
for you to fetch changes up to 24e76b00e43f2efcdfa8e32fc3bcf13f7fea1003:
ARM: hi3xxx: add hotplug support (2013-11-25 11:02:33 +0800)
----------------------------------------------------------------
Enable Hisilicon Hi3620 SoC platform
----------------------------------------------------------------
Haojian Zhuang (4):
ARM: hi3xxx: add board support with device tree
ARM: dts: enable hi4511 with device tree
ARM: config: enable hi3xxx in multi_v7_defconfig
ARM: config: add defconfig for Hi3xxx
Zhangfei Gao (2):
ARM: hi3xxx: add smp support
ARM: hi3xxx: add hotplug support
Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 32 ++++
arch/arm/Kconfig | 2 +
arch/arm/Makefile | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/hi3620.dtsi | 556
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/hi4511.dts | 648
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
arch/arm/configs/hi3xxx_defconfig | 56
+++++++
arch/arm/configs/multi_v7_defconfig | 1 +
arch/arm/mach-hi3xxx/Kconfig | 15 ++
arch/arm/mach-hi3xxx/Makefile | 7 +
arch/arm/mach-hi3xxx/core.h | 15 ++
arch/arm/mach-hi3xxx/hi3xxx.c | 94
++++++++++++
arch/arm/mach-hi3xxx/hotplug.c | 200
+++++++++++++++++++++++++
arch/arm/mach-hi3xxx/platsmp.c | 89
+++++++++++
14 files changed, 1717 insertions(+)
create mode 100644
Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
create mode 100644 arch/arm/boot/dts/hi3620.dtsi
create mode 100644 arch/arm/boot/dts/hi4511.dts
create mode 100644 arch/arm/configs/hi3xxx_defconfig
create mode 100644 arch/arm/mach-hi3xxx/Kconfig
create mode 100644 arch/arm/mach-hi3xxx/Makefile
create mode 100644 arch/arm/mach-hi3xxx/core.h
create mode 100644 arch/arm/mach-hi3xxx/hi3xxx.c
create mode 100644 arch/arm/mach-hi3xxx/hotplug.c
create mode 100644 arch/arm/mach-hi3xxx/platsmp.c
^ permalink raw reply [flat|nested] 3+ messages in thread
* [GIT PULL][for 3.14] pull request to enable Hisilicon SoC from pxa git tree
2013-11-25 3:07 [GIT PULL][for 3.14] pull request to enable Hisilicon SoC from pxa git tree Haojian Zhuang
@ 2013-11-25 4:05 ` Olof Johansson
2013-11-25 5:18 ` Haojian Zhuang
0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2013-11-25 4:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Sun, Nov 24, 2013 at 7:07 PM, Haojian Zhuang
<haojian.zhuang@gmail.com> wrote:
> Hi Olof & Kevin,
>
> Here's the pull request from pxa git tree to enable Hisilicon Hi3620 SoC.
> Please help to merge.
>
> Best Regards
> Haojian
>
> The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
>
> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
>
> are available in the git repository at:
>
> http://git.kernel.org/pub/scm/linux/kernel/git/hzhuang1/linux.git
> tags/hisilicon-init
Hi,
Overall this looks good, but I do have a few comments:
First, I had a comment on one of the patches. It's your choice if you
want to address it by respinning or by an incremental patch on top,
but please address those.
Second, it seems appropriate for you to start a second git tree for
hisilicon, instead of reusing the pxa one -- at least if you expect
more activity on that platform over time. You can create new trees on
kernel.org as you see fit, so there's no reason not to.
Thirdly, I noticed some patches have a Signed-off-by from your linaro
address, and a committer ID of your gmail account. Please be
consistent in which one you use since last S-o-b and committer should
match -- you might want to reconfigure git to use the linaro one but
either way is fine with me as long as it is consistent.
Finally, you've had a lot of review cycles, but surprisingly not many
acked-by's on the final patches. See if you can get some out of the
people whose feedback you have addressed.
Since you have to rebuild the branch to fix committer id, you might
want to just fold in the changes from my review, but I'll leave that
up to you.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
* [GIT PULL][for 3.14] pull request to enable Hisilicon SoC from pxa git tree
2013-11-25 4:05 ` Olof Johansson
@ 2013-11-25 5:18 ` Haojian Zhuang
0 siblings, 0 replies; 3+ messages in thread
From: Haojian Zhuang @ 2013-11-25 5:18 UTC (permalink / raw)
To: linux-arm-kernel
On 11/25/2013 12:05 PM, Olof Johansson wrote:
> Hi,
>
>
> On Sun, Nov 24, 2013 at 7:07 PM, Haojian Zhuang
> <haojian.zhuang@gmail.com> wrote:
>> Hi Olof & Kevin,
>>
>> Here's the pull request from pxa git tree to enable Hisilicon Hi3620 SoC.
>> Please help to merge.
>>
>> Best Regards
>> Haojian
>>
>> The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
>>
>> Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
>>
>> are available in the git repository at:
>>
>> http://git.kernel.org/pub/scm/linux/kernel/git/hzhuang1/linux.git
>> tags/hisilicon-init
>
> Hi,
>
> Overall this looks good, but I do have a few comments:
>
> First, I had a comment on one of the patches. It's your choice if you
> want to address it by respinning or by an incremental patch on top,
> but please address those.
Let me fix those. And send a second pull request.
>
> Second, it seems appropriate for you to start a second git tree for
> hisilicon, instead of reusing the pxa one -- at least if you expect
> more activity on that platform over time. You can create new trees on
> kernel.org as you see fit, so there's no reason not to.
>
Since hisilicon guys want to maintainer their SoC by themselves. This
patch set submitted by me is temporary in my git tree. They'll take over
my job in these weeks. So they'll submit pull request instead, and I'll
only submit patches.
And this git tree will be only used for pxa/mmp since github isn't
preferred. I'll update the MAINTAINER document instead.
> Thirdly, I noticed some patches have a Signed-off-by from your linaro
> address, and a committer ID of your gmail account. Please be
> consistent in which one you use since last S-o-b and committer should
> match -- you might want to reconfigure git to use the linaro one but
> either way is fine with me as long as it is consistent.
>
OK. Let me make them consistent.
> Finally, you've had a lot of review cycles, but surprisingly not many
> acked-by's on the final patches. See if you can get some out of the
> people whose feedback you have addressed.
>
Let me try.
Best Regards
Haojian
>
> Since you have to rebuild the branch to fix committer id, you might
> want to just fold in the changes from my review, but I'll leave that
> up to you.
>
> -Olof
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-25 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 3:07 [GIT PULL][for 3.14] pull request to enable Hisilicon SoC from pxa git tree Haojian Zhuang
2013-11-25 4:05 ` Olof Johansson
2013-11-25 5:18 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).