From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Mon, 25 Nov 2013 12:59:45 +0200 [thread overview]
Message-ID: <52932DA1.8040204@ti.com> (raw)
In-Reply-To: <201311231857.47104.arnd@arndb.de>
On 11/23/2013 07:57 PM, Arnd Bergmann wrote:
> On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
>> @@ -7,6 +7,10 @@ Required properties:
>>
>> - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> + Required only for Keystone arch.
>> + See clock-bindings.txt
>> +
>> Optional properties:
>>
>> - timeout-sec: Contains the watchdog timeout in seconds
>
> I think it should really be listed under "Optional properties" and the
> reference to Keystone removed. Note how the binding would need
> to change otherwise if another platform started to use the clock, which
> is a little silly.
>
> Arnd
>
Ok, I'll move clocks property under "Optional properties" and describe it
as following:
Optional properties:
- timeout-sec : Contains the watchdog timeout in seconds
- clocks: phandle reference to the controller clock.
Needed if platform uses clocks.
See clock-bindings.txt
FYI:
The new patch series had been already presented, where the patches
"watchdog: davinci: add "clocks" property" and
"watchdog: davinci: reuse driver for keystone arch" were combined.
http://www.spinics.net/lists/devicetree/msg12542.html
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2013-11-25 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property ivan.khoronzhuk
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:28 ` Guenter Roeck
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-23 17:57 ` Arnd Bergmann
2013-11-25 10:59 ` ivan.khoronzhuk [this message]
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:41 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52932DA1.8040204@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).