From: haojian.zhuang@gmail.com (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE
Date: Wed, 27 Nov 2013 09:26:21 +0800 [thread overview]
Message-ID: <52954A3D.3040108@gmail.com> (raw)
In-Reply-To: <20131126133731.GE28642@pengutronix.de>
On 11/26/2013 09:37 PM, Uwe Kleine-K?nig wrote:
> Hello,
>
> [Cc: += akpm]
>
> On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-K?nig wrote:
>> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform
>> specific header <mach/timex.h>. There are plans to stop using and kill
>> these platform specific headers. So fix the only user of pxa's
>> <mach/timex.h> to not use it.
>>
>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Who is looking for this patch?
>
> Best regards
> Uwe
>
>> ---
>> It would be nice to use the clk API to find the tick rate, but I didn't
>> find any clk to use.
>> ---
>> drivers/rtc/rtc-pxa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
>> index a355f2b..0ba07e1 100644
>> --- a/drivers/rtc/rtc-pxa.c
>> +++ b/drivers/rtc/rtc-pxa.c
>> @@ -32,7 +32,7 @@
>>
>> #include <mach/hardware.h>
>>
>> -#define TIMER_FREQ CLOCK_TICK_RATE
>> +#define TIMER_FREQ get_clock_tick_rate()
>> #define RTC_DEF_DIVIDER (32768 - 1)
>> #define RTC_DEF_TRIM 0
>> #define MAXFREQ_PERIODIC 1000
>> --
>> 1.7.10.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
I think that Alessandro could help to merge.
Alessandro,
Is it right?
Regards
Haojian
next prev parent reply other threads:[~2013-11-27 1:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 20:25 [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE Uwe Kleine-König
2013-11-13 5:37 ` Haojian Zhuang
2013-11-26 13:37 ` Uwe Kleine-König
2013-11-27 1:26 ` Haojian Zhuang [this message]
2013-12-07 20:07 ` Robert Jarzmik
2013-12-07 22:30 ` [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ Uwe Kleine-König
2013-12-08 10:45 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52954A3D.3040108@gmail.com \
--to=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).