From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support
Date: Thu, 28 Nov 2013 22:13:06 +0400 [thread overview]
Message-ID: <529787B2.7010208@cogentembedded.com> (raw)
In-Reply-To: <4401360.Outsal0mcb@avalon>
Hello.
On 28-11-2013 21:14, Laurent Pinchart wrote:
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + eeprom: 24c128 at 50 {
>>>> + compatible = "at,24c128";
>>> Minor nit: Should be a vendor name, not the name of the driver
>> Moreover, the node should be named generically, like "flash at 50", not
>> "24c128 at 50".
> Or, given that it's an eeprom, "eeprom at 50" ? :-)
At least ePAPR spec. only has "flash".
WBR, Sergei
next prev parent reply other threads:[~2013-11-28 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 8:27 [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Magnus Damm
2013-11-27 8:27 ` [PATCH 01/04] ARM: shmobile: r7s72100 GPIO and PINCTRL device nodes Magnus Damm
2013-11-27 8:27 ` [PATCH 02/04] ARM: shmobile: Genmai LED1 and LED2 support Magnus Damm
2013-11-27 11:16 ` Laurent Pinchart
2013-11-27 8:28 ` [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support Magnus Damm
2013-11-27 11:04 ` Wolfram Sang
2013-11-28 17:11 ` Sergei Shtylyov
2013-11-28 17:14 ` Laurent Pinchart
2013-11-28 18:13 ` Sergei Shtylyov [this message]
2013-11-27 11:15 ` Laurent Pinchart
2013-11-28 0:44 ` Magnus Damm
2013-11-28 0:46 ` Laurent Pinchart
2013-11-27 8:28 ` [PATCH 04/04] ARM: shmobile: Genmai SCIF2 PINCTRL configuration Magnus Damm
2013-11-27 11:16 ` Laurent Pinchart
2013-11-27 11:13 ` [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529787B2.7010208@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).