From: philippe.retornaz@gmail.com (Philippe Rétornaz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init
Date: Mon, 02 Dec 2013 09:30:31 +0100 [thread overview]
Message-ID: <529C4527.3040707@gmail.com> (raw)
In-Reply-To: <1385805188-5597-1-git-send-email-shc_work@mail.ru>
Le 30/11/2013 10:53, Alexander Shiyan a ?crit :
> If this driver being loaded from devicetree, the pdata is NULL. This
> cause kernel Oops when "fsl,mc13xxx-uses-codec" and/or
> "fsl,mc13xxx-uses-touch" properties is specified.
>
Well, the codec and touch are not supported if DT is used, thus why
bothering ? Just don't specify thoses properties.
IMHO it would be better to either implement full DT support in the
subdevices or removing the check for the fsl,mc13xxx-uses-codec and
fsl,mc13xxx-uses-touch in mc13xxx_probe_flags_dt().
If it's not supported let's not lie about it.
Regards,
Philippe
next prev parent reply other threads:[~2013-12-02 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 9:53 [PATCH RESEND] mfd: mc13xxx: Fix null pointer dereference in mc13xxx_common_init Alexander Shiyan
2013-12-02 8:30 ` Philippe Rétornaz [this message]
2013-12-02 10:54 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2013-11-30 4:55 Alexander Shiyan
2013-11-30 9:34 ` Michael Grzeschik
2013-11-30 9:52 ` Alexander Shiyan
2013-12-02 10:56 ` Lee Jones
2013-12-02 11:11 ` Alexander Shiyan
2013-12-02 11:17 ` Lee Jones
2013-12-02 11:53 ` Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C4527.3040707@gmail.com \
--to=philippe.retornaz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).