From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: add usart3 alias to dtsi
Date: Mon, 2 Dec 2013 13:47:29 +0100 [thread overview]
Message-ID: <529C8161.5050005@atmel.com> (raw)
In-Reply-To: <529C70C7.9050707@overkiz.com>
On 02/12/2013 12:36, boris brezillon :
> Hi Nicolas,
>
> Le 02/12/2013 11:13, Nicolas Ferre a ?crit :
>> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
>> Preripheral node and pinctrl declarations are already in the
>> at91sam9x5_usart3.dtsi file.
>>
>> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
>> arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
>> index 17b879990914..d4650b4e9ebb 100644
>> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
>> @@ -14,6 +14,10 @@
>> model = "Atmel AT91SAM9G25 SoC";
>> compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>>
>> + aliases {
>> + serial4 = &usart3;
>> + };
>> +
>
> Shouldn't this go into at91sam9x5_usart3.dtsi ?
> This way you would have the same alias for all the SoCs supporting usart3.
Indeed, I was focused on the product itself but it definitively makes
sense to move it in the at91sam9x5_usart3.dtsi
Thanks, bye,
>> ahb {
>> apb {
>> pinctrl at fffff400 {
>> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
>> index c2554219f7a4..aceee86f60eb 100644
>> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
>> @@ -15,6 +15,10 @@
>> model = "Atmel AT91SAM9X25 SoC";
>> compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>>
>> + aliases {
>> + serial4 = &usart3;
>> + };
>> +
>> ahb {
>> apb {
>> pinctrl at fffff400 {
>
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-12-02 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 10:13 [PATCH] ARM: at91: add usart3 alias to dtsi Nicolas Ferre
2013-12-02 11:36 ` boris brezillon
2013-12-02 12:47 ` Nicolas Ferre [this message]
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
2013-12-02 12:55 ` boris brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C8161.5050005@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).