From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@st.com (srinivas kandagatla) Date: Mon, 2 Dec 2013 13:26:49 +0000 Subject: [PATCH v3 36/36] ARM: STi: Add support for the FSM Serial Flash Controller In-Reply-To: <20131202132013.GF31626@lee--X1> References: <1385727565-25794-1-git-send-email-lee.jones@linaro.org> <1385727565-25794-37-git-send-email-lee.jones@linaro.org> <529C858B.1040601@st.com> <20131202132013.GF31626@lee--X1> Message-ID: <529C8A99.1020204@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/12/13 13:20, Lee Jones wrote: >>> + /* FSM */ >>> + spifsm: spifsm at fe902000{ >>> + compatible = "st,spi-fsm", "simple-bus"; >> "simple-bus" is redundant here. > > Yes I agree, good spot. > > I removed it from the Documentation, but missed this one. > > If I remove it, can I add your Ack for the remainder of the patch? Yes, Acked-by: Srinivas Kandagatla You should be aware that arch/arm/boot/dts/stih416-b2105.dts is not in mainline yet. Thanks, srini > >>> + reg = <0xfe902000 0x1000>; >>> + reg-names = "spi-fsm"; >>> + pinctrl-0 = <&pinctrl_fsm>; >>> + >>> + st,syscfg = <&syscfg_rear>; >>> + st,boot-device-reg = <0x958>; >>> + st,boot-device-spi = <0x1a>; >>> + >>> + status = "okay"; >>> + }; >