From: david.vrabel@citrix.com (David Vrabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64
Date: Tue, 3 Dec 2013 17:10:50 +0000 [thread overview]
Message-ID: <529E109A.7050700@citrix.com> (raw)
In-Reply-To: <1386085237-8334-1-git-send-email-julien.grall@linaro.org>
On 03/12/13 15:40, Julien Grall wrote:
> On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will
> result on different structure from Xen and Linux repositories.
>
> As Linux is using __packed__ attribute, it must have a 4-bytes padding before
> each "id" field.
>
> This change breaks guest block support with older kernel. IMHO, it's acceptable
> because Xen on ARM is still on Tech Preview and the hypercall ABI is not yet
> freezed.
>
> Only one architecture (x86_32) doesn't have 64-bit ABI for the block interface.
> Don't add padding if Linux is compiled for this architecture.
I'm now satisfied that this is the right thing to do.
Acked-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2013-12-03 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 15:40 [PATCH v2] xen/block: Correctly define structures in public headers on ARM32 and ARM64 Julien Grall
2013-12-03 16:00 ` One Thousand Gnomes
2013-12-03 16:19 ` Julien Grall
2013-12-03 16:32 ` One Thousand Gnomes
2013-12-03 16:41 ` Ian Campbell
2013-12-03 17:03 ` One Thousand Gnomes
2013-12-03 18:03 ` Konrad Rzeszutek Wilk
2013-12-03 17:10 ` David Vrabel [this message]
2013-12-03 18:01 ` Konrad Rzeszutek Wilk
2013-12-12 14:19 ` [Xen-devel] " Ian Campbell
2013-12-12 15:11 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E109A.7050700@citrix.com \
--to=david.vrabel@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).