linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: Remove unused variables
Date: Wed, 04 Dec 2013 11:26:06 +0100	[thread overview]
Message-ID: <529F033E.9020608@gmail.com> (raw)
In-Reply-To: <1386152565-26524-1-git-send-email-thierry.reding@gmail.com>

On 12/04/2013 11:22 AM, Thierry Reding wrote:
> The conf and of_id variables are assigned but never used, so they may as
> well just be removed.
> 
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

Acked-by: Daniel Mack <zonque@gmail.com>

> ---
>  arch/arm/mach-pxa/irq.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index b6cc1816463e..0eecd83c624e 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
>  void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>  {
>  	struct device_node *node;
> -	const struct of_device_id *of_id;
> -	struct pxa_intc_conf *conf;
>  	struct resource res;
>  	int n, ret;
>  
> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>  		pr_err("Failed to find interrupt controller in arch-pxa\n");
>  		return;
>  	}
> -	of_id = of_match_node(intc_ids, node);
> -	conf = of_id->data;
>  
>  	ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
>  				   &pxa_internal_irq_nr);
> 

  reply	other threads:[~2013-12-04 10:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 10:22 [PATCH] ARM: pxa: Remove unused variables Thierry Reding
2013-12-04 10:26 ` Daniel Mack [this message]
2013-12-04 11:12   ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529F033E.9020608@gmail.com \
    --to=zonque@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).