linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Enable Calxeda cpufreq driver on arm64
@ 2013-12-05  0:23 Rob Herring
  2013-12-05  0:23 ` [PATCH 1/2] cpufreq: enable ARM drivers " Rob Herring
  2013-12-05  0:23 ` [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64 Rob Herring
  0 siblings, 2 replies; 7+ messages in thread
From: Rob Herring @ 2013-12-05  0:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: Rob Herring <rob.herring@calxeda.com>

This series enables cpufreq subsystem and the highbank-cpufreq driver
for arm64. Nothing more really than sorting kconfig options to allow
the driver to build. There's no reason for the driver to depend on
ARCH_HIGHBANK and I'm trying to avoid adding that (or a new option)
for arm64.

Rob

Rob Herring (2):
  cpufreq: enable ARM drivers on arm64
  cpufreq: highbank: rework the kconfig dependencies for arm64

 arch/arm64/Kconfig          |  8 ++++++++
 drivers/cpufreq/Kconfig     |  2 +-
 drivers/cpufreq/Kconfig.arm | 14 ++++++--------
 3 files changed, 15 insertions(+), 9 deletions(-)

-- 
1.8.3.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] cpufreq: enable ARM drivers on arm64
  2013-12-05  0:23 [PATCH 0/2] Enable Calxeda cpufreq driver on arm64 Rob Herring
@ 2013-12-05  0:23 ` Rob Herring
  2013-12-05 18:16   ` Mark Brown
  2013-12-05  0:23 ` [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64 Rob Herring
  1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2013-12-05  0:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: Rob Herring <rob.herring@calxeda.com>

Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq
drivers. The power menu is needed for OPP support. At least on Calxeda
systems, the same cpufreq driver is used for arm and arm64 based
systems.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: cpufreq at vger.kernel.org
Cc: linux-pm at vger.kernel.org
---
 arch/arm64/Kconfig      | 8 ++++++++
 drivers/cpufreq/Kconfig | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 88c8b6c1..1808dd1 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -276,6 +276,14 @@ config SYSVIPC_COMPAT
 
 endmenu
 
+menu "Power management options"
+
+source "kernel/power/Kconfig"
+
+source "drivers/cpufreq/Kconfig"
+
+endmenu
+
 source "net/Kconfig"
 
 source "drivers/Kconfig"
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 38093e2..e26fdcd 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -195,7 +195,7 @@ source "drivers/cpufreq/Kconfig.x86"
 endmenu
 
 menu "ARM CPU frequency scaling drivers"
-depends on ARM
+depends on ARM || ARM64
 source "drivers/cpufreq/Kconfig.arm"
 endmenu
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64
  2013-12-05  0:23 [PATCH 0/2] Enable Calxeda cpufreq driver on arm64 Rob Herring
  2013-12-05  0:23 ` [PATCH 1/2] cpufreq: enable ARM drivers " Rob Herring
@ 2013-12-05  0:23 ` Rob Herring
  2013-12-16  8:54   ` Viresh Kumar
  1 sibling, 1 reply; 7+ messages in thread
From: Rob Herring @ 2013-12-05  0:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: Rob Herring <rob.herring@calxeda.com>

Make ARM_HIGHBANK_CPUFREQ not depend on ARCH_HIGHBANK to enable on
arm64 and also give better build converage. Change the selects to be
same depends as the cpu0 driver. Otherwise, we can get kconfig select
errors. Also, add missing depends for PL320_MBOX.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: cpufreq at vger.kernel.org
Cc: linux-pm at vger.kernel.org
---
 drivers/cpufreq/Kconfig.arm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index ce52ed9..0d7130d 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -65,16 +65,14 @@ config ARM_EXYNOS5440_CPUFREQ
 	  If in doubt, say N.
 
 config ARM_HIGHBANK_CPUFREQ
-	tristate "Calxeda Highbank-based"
-	depends on ARCH_HIGHBANK
-	select GENERIC_CPUFREQ_CPU0
+	tristate "Calxeda ECX based"
+	depends on HAVE_CLK && REGULATOR && OF
+	depends on PL320_MBOX
+	select ARCH_HAS_OPP
 	select PM_OPP
-	select REGULATOR
-
-	default m
+	select GENERIC_CPUFREQ_CPU0
 	help
-	  This adds the CPUFreq driver for Calxeda Highbank SoC
-	  based boards.
+	  This adds the CPUFreq driver for Calxeda based SoCs.
 
 	  If in doubt, say N.
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 1/2] cpufreq: enable ARM drivers on arm64
  2013-12-05  0:23 ` [PATCH 1/2] cpufreq: enable ARM drivers " Rob Herring
@ 2013-12-05 18:16   ` Mark Brown
  2013-12-05 20:03     ` Rob Herring
  0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2013-12-05 18:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Dec 04, 2013 at 06:23:13PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq
> drivers. The power menu is needed for OPP support. At least on Calxeda
> systems, the same cpufreq driver is used for arm and arm64 based
> systems.

If this needs any revisions (I'd be surprised but...) can you please
keep me on the CCs?  I intend to pull this into LSK if that's OK since I
was about to do roughly the same thing for it and upstream the result.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131205/38178928/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] cpufreq: enable ARM drivers on arm64
  2013-12-05 18:16   ` Mark Brown
@ 2013-12-05 20:03     ` Rob Herring
  2013-12-05 20:35       ` Mark Brown
  0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2013-12-05 20:03 UTC (permalink / raw)
  To: linux-arm-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/05/2013 12:16 PM, Mark Brown wrote:
> On Wed, Dec 04, 2013 at 06:23:13PM -0600, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>> 
>> Enable cpufreq and power kconfig menus on arm64 along with arm
>> cpufreq drivers. The power menu is needed for OPP support. At
>> least on Calxeda systems, the same cpufreq driver is used for arm
>> and arm64 based systems.
> 
> If this needs any revisions (I'd be surprised but...) can you
> please keep me on the CCs?  I intend to pull this into LSK if
> that's OK since I was about to do roughly the same thing for it and
> upstream the result.

Will do, but I'm surprised we're at the point on arm64 of needing LSK.
There's a couple of subsystems that need enabling. I've posted EDAC
patches (need to send v3). cpuidle is another. Probably some more I
haven't looked at.

Rob

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSoNwoAAoJEMhvYp4jgsXiZmMH/0h6Zubjcqhkrx/UGYa47j7r
EU0stg3/sJvyNGlo+jDV7ljEEtHVmJyxINORDFCGBlYLnsVisYLY9Q+YRZH7PSrJ
O7eloK2LdceYabpoe0QFBXuB+VQ5uUiVH5ts9I3JLp3bxvBwjjM6rsYdKHwx4VHp
IAkCgRZZAC9WLi+F4vteC9oh+S5UoXIKpTr1ei/y21czZ6Gw8tGhrGX4fc3IcFSy
4OPFb41/RQkJL5U4KCRUrMS+8wOmJy3rLcTvjxXz85b5ht9+i01AUt6yN9mwGrjp
a/Y5pFzADIXvhlJDYt4KBK+xgYyL6keWSc2cQyW08MhyNRjr2qXzOaw3qb3VvhI=
=SJ+q
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] cpufreq: enable ARM drivers on arm64
  2013-12-05 20:03     ` Rob Herring
@ 2013-12-05 20:35       ` Mark Brown
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2013-12-05 20:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 05, 2013 at 02:03:52PM -0600, Rob Herring wrote:

> Will do, but I'm surprised we're at the point on arm64 of needing LSK.

ARMv8 isn't just for servers, and of course there's the desire to have
the software as ready as early as it can be!

> There's a couple of subsystems that need enabling. I've posted EDAC
> patches (need to send v3). cpuidle is another. Probably some more I
> haven't looked at.

Right, cpuidle is in progress - Lorenzo has been posting patches for
that:  

   http://lwn.net/Articles/574950/

There's some active work in the trace and debug area too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131205/d2c54368/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64
  2013-12-05  0:23 ` [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64 Rob Herring
@ 2013-12-16  8:54   ` Viresh Kumar
  0 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2013-12-16  8:54 UTC (permalink / raw)
  To: linux-arm-kernel

On 5 December 2013 05:53, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Make ARM_HIGHBANK_CPUFREQ not depend on ARCH_HIGHBANK to enable on
> arm64 and also give better build converage. Change the selects to be

s/converage/coverage

> same depends as the cpu0 driver. Otherwise, we can get kconfig select
> errors. Also, add missing depends for PL320_MBOX.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: cpufreq at vger.kernel.org
> Cc: linux-pm at vger.kernel.org
> ---
>  drivers/cpufreq/Kconfig.arm | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ce52ed9..0d7130d 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -65,16 +65,14 @@ config ARM_EXYNOS5440_CPUFREQ
>           If in doubt, say N.
>
>  config ARM_HIGHBANK_CPUFREQ
> -       tristate "Calxeda Highbank-based"
> -       depends on ARCH_HIGHBANK
> -       select GENERIC_CPUFREQ_CPU0
> +       tristate "Calxeda ECX based"
> +       depends on HAVE_CLK && REGULATOR && OF
> +       depends on PL320_MBOX
> +       select ARCH_HAS_OPP
>         select PM_OPP
> -       select REGULATOR
> -
> -       default m
> +       select GENERIC_CPUFREQ_CPU0
>         help
> -         This adds the CPUFreq driver for Calxeda Highbank SoC
> -         based boards.
> +         This adds the CPUFreq driver for Calxeda based SoCs.
>
>           If in doubt, say N.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org> for both patches.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-12-16  8:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05  0:23 [PATCH 0/2] Enable Calxeda cpufreq driver on arm64 Rob Herring
2013-12-05  0:23 ` [PATCH 1/2] cpufreq: enable ARM drivers " Rob Herring
2013-12-05 18:16   ` Mark Brown
2013-12-05 20:03     ` Rob Herring
2013-12-05 20:35       ` Mark Brown
2013-12-05  0:23 ` [PATCH 2/2] cpufreq: highbank: rework the kconfig dependencies for arm64 Rob Herring
2013-12-16  8:54   ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).