From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: regulator-core has_full_constraints set too late for dt using boards ?
Date: Thu, 12 Dec 2013 11:14:10 +0100 [thread overview]
Message-ID: <52A98C72.2040203@redhat.com> (raw)
In-Reply-To: <20131211160225.GB11468@sirena.org.uk>
Hi,
On 12/11/2013 05:02 PM, Mark Brown wrote:
> On Wed, Dec 11, 2013 at 04:43:01PM +0100, Hans de Goede wrote:
>
>> While looking into making regulator_get_optional not print
>> an error when no regulator is found, I've noticed that
>> for dt enabled boards, has_full_constraints is not set
>> until regulator_init_complete() runs, which is a
>> late_initcall.
>
>> This means that it gets set after it has already been checked
>> from calls like regulator_get which are likely done by init
>> functions running earlier.
>
>> This seems wrong ...
>
> Please look at the current code, that's not how this works any more.
More current then 3.13-rc3 ? Because that is what I've been looking at.
I could be completely wrong of course. Either way could you give a few
hints as to how my interpretation of how this works is wrong ?
Thanks & Regards,
Hans
next prev parent reply other threads:[~2013-12-12 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 15:43 regulator-core has_full_constraints set too late for dt using boards ? Hans de Goede
2013-12-11 16:02 ` Mark Brown
2013-12-12 10:14 ` Hans de Goede [this message]
2013-12-12 10:42 ` Mark Brown
2013-12-12 12:19 ` Hans de Goede
2013-12-12 12:23 ` Mark Brown
2013-12-12 13:05 ` Hans de Goede
2013-12-12 13:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A98C72.2040203@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).