From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
Date: Fri, 13 Dec 2013 22:57:33 +0100 [thread overview]
Message-ID: <52AB82CD.3040100@linaro.org> (raw)
In-Reply-To: <1386967759-12952-1-git-send-email-andre.przywara@linaro.org>
On 12/13/2013 09:49 PM, Andre Przywara wrote:
> Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
> cpuidle driver to a platform driver, copying the __init tag from the
> _init() to the newly used _probe() function. However, "probe should
> not be __init." (Rob said ;-)
> Remove the __init tag to fix a section mismatch in the Calxeda
> cpuidle driver.
>
> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
> ---
Applied to my tree for 3.14.
Thanks for the fix.
-- Daniel
> drivers/cpuidle/cpuidle-calxeda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
> index 3679563..6e51114 100644
> --- a/drivers/cpuidle/cpuidle-calxeda.c
> +++ b/drivers/cpuidle/cpuidle-calxeda.c
> @@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
> .state_count = 2,
> };
>
> -static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
> +static int calxeda_cpuidle_probe(struct platform_device *pdev)
> {
> return cpuidle_register(&calxeda_idle_driver, NULL);
> }
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-12-13 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 20:49 [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Andre Przywara
2013-12-13 21:57 ` Daniel Lezcano [this message]
2013-12-13 22:47 ` Andre Przywara
2013-12-14 9:04 ` Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 11:00 [GIT PULL] ARM : cpuidle: 3.13 fix Daniel Lezcano
2013-12-30 11:02 ` [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB82CD.3040100@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).